Adding draft of Chapter 12 #37
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,767 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,767 @@ | |||
| { | |||
There was a problem hiding this comment.
Why do you say "the default option?" I thought the default was without replacement (replace=False).
Reply via ReviewNB
| @@ -0,0 +1,767 @@ | |||
| { | |||
There was a problem hiding this comment.
If think if you underline or bold the terms "empirical distribution" and "probability distribution" it will help to remind readers the difference and relationship between the two, which they could look into to better construct an understanding and refer to more information in the probability chapter/lectures
Reply via ReviewNB
| @@ -0,0 +1,767 @@ | |||
| { | |||
There was a problem hiding this comment.
Is there an outside reference (like maybe the stats book Dan wanted to refer students to for the probability lecture) that explains this a bit more? It's a bit out of context and left field. Like, how did one ascertain these mathematical definitions of the mean and variance?
Is it assumed one would know this if they have already studied/familiar with the Law of Large Numbers? If so, then I guess that reference you mention would rectify the above.
Reply via ReviewNB
| @@ -0,0 +1,767 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,296 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,296 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,383 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,383 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| { | |||
There was a problem hiding this comment.
The Probability Distributions paragraph is a bit of a mouthful for someone that may be unfamiliar. Could you possibly offer a simple, anecdotal example to illustrate the meaning of the terms random variables, sample space, and probability distribution after this paragraph? I think having such an example, and directly pointing out which terms are what in the example, could help in comprehending this paragraph.
Just to clarify, you defined variance as σ^2(X) and then said standard deviation is the square root of variance and is σ^2(X). How so? it wouldn't be sqrt(σ^2(X))? Just want to make sure I'm understanding...
denoted by s is the -> denoted by s, is the
Reply via ReviewNB
textbook/_toc.yml
Outdated
| - file: 10/1/uniform | ||
| - file: 10/2/normal | ||
| - file: 10/3/binomial |
There was a problem hiding this comment.
FYI: Just a typo but your TOC updates refer to the chapter 10 directory rather than 12.
textbook/12/empirical-distributions.ipynb:: WARNING: toctree contains reference to nonexisting document '10/1/uniform' [etoc.ref]
textbook/12/empirical-distributions.ipynb:: WARNING: toctree contains reference to nonexisting document '10/2/normal' [etoc.ref]
textbook/12/empirical-distributions.ipynb:: WARNING: toctree contains reference to nonexisting document '10/3/binomial' [etoc.ref]
textbook/12/1/uniform.ipynb: WARNING: document isn't included in any toctree
textbook/12/2/normal.ipynb: WARNING: document isn't included in any toctree
textbook/12/3/binomial.ipynb: WARNING: document isn't included in any toctree
| @@ -0,0 +1,60 @@ | |||
| { | |||
There was a problem hiding this comment.
This looks like a typo resulting in a broken image:
Rather than say a link:
[Chapter 11](../11/Probability.html)
Reply via ReviewNB
There was a problem hiding this comment.
You are absolutely right that the ! is a typeo. The file should be .html instead of .ipynb? Will a rendered html file be in that folder in the built version of the textbook? Asking because I think I made this mistake other places if so...
There was a problem hiding this comment.
Yes, you're right. The ambiguity in authoring such things is honestly frustrating.
There are generally three ways about it:
- Write proper HTML, which will be passed through as-is, and work in the textbook.
- Write Markdown, which should be fixed up before conversion to HTML.
- Use a Jupyter Book (Sphinx) helper, which will ostensibly make things easier, (but this markup may be even less natural).
And so, any of the following would work:
<a href="../11/Probability.html">Chapter 11</a>[Chapter 11](../11/Probability.ipynb)[](../11/Probability.ipynb)[Chapter 11](../11/Probability)[](../11/Probability){doc}`Chapter 11 <../11/Probability>`{doc}`../11/Probability`
That is, all references are relative, and:
- HTML should presume the full final document path (with
.htmlsuffix) - Markdown may either refer to the actual file name (including
.ipynbsuffix) or omit the suffix entirely - Sphinx-style references may not include the file suffix
- Markdown and Sphinx references may omit the link text, in which case it will be derived from the referenced document's full header, (in this case
Probability: Mathematical/Theoretical and Computational Approaches).
So! Yes, in short, this would do the trick, (among other options)…:
[Chapter 11](../11/Probability.ipynb)
There was a problem hiding this comment.
Goodness, so confusing! Thank you for clarifying! I have pushed the change, so hopefully it works now! Please let me know if other changes are needed
There was a problem hiding this comment.
Thanks! Looks good to me. So this is ready to merge?
* edit toc and remove placeholder * add text * Edits based on meeting 12/6 * fixed chapter reference
No description provided.