-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to toc ch3 #40
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
To reiterate, there has never been material in this repository belonging to Data-8. (I'm guessing that's not news. I just want to be clear. Here is where this was last discussed in full.) Rather, these materials were put together from a BSD-licensed demo. It sounds like the team has plans for new content to take this place, and perhaps even regardless of the above. Sounds good. I'll add that at least a couple of these programming chapters I wrote from scratch for the textbook, (in addition to the chapter on DataFrames), way back in 2020. Perhaps these are no longer needed. But they are particularly distinct from the above: |
What I meant about the data8 material is that it is in data8 (not necessarily belonging to). I think the consensus is that we don't want to include any information that is also in their textbook (including the demo material). I am sorry if I also removed content that you wrote, I was told it was all the same and honestly didn't check. Please add any of your material back to this section and we can rewrite the ones that were replicated. We also wanted our section names to be distinct from those used in data8 which is why we changed some of those as well. Maybe we can reformat some of what you had into these new sections? For example, including call-expression (built-in functions) in the same section as functions in general. Or moving some of the sequences material into the data structures chapter and keeping some in a new section for dictionaries. Would this be ok with you? If so, you are welcome to do that so that it is written the way you would like. |
Sure, understood. And, to be sure, what I'd written (way back when) was done with an older conception of the chapter and textbook in mind. I hope it can still be of use, but I'd certainly understand if it weren't or if it had to be adapted. I'll restore what I'd written. And it sounds like we can just see what there is to do with it. |
3000999
to
74c367c
Compare
74c367c
to
8fbe5f4
Compare
OK:
|
add placeholders for new content (retain non-demo originating content: Sequences) Co-authored-by: Jesse London <[email protected]>
8fbe5f4
to
3a25d98
Compare
Removed data8 material, changed section names, added placeholders for people to work off of to, hopefully, reduce merge conflicts as we all write the chapter together