Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version #3

Merged
merged 4 commits into from
Jun 27, 2023
Merged

update version #3

merged 4 commits into from
Jun 27, 2023

Conversation

sorelfitzgibbon
Copy link
Contributor

@sorelfitzgibbon sorelfitzgibbon commented Jun 23, 2023

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

My command:

docker build -t test-bedtools .
docker run -it --rm test-bedtools whoami
docker run -it --rm test-bedtools bedtools

Output:

bldocker

bedtools is a powerful toolset for genome arithmetic.

Version:   v2.31.0
About:     developed in the quinlanlab.org and by many contributors worldwide.
Docs:      http://bedtools.readthedocs.io/
...

Dockerfile Outdated
@@ -1,8 +1,9 @@
FROM blcdsdockerregistry/bl-base:1.0.0 AS builder
ARG MINIFORGE_VERSION=22.9.0-2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the latest version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Updated to latest mambaforge: v23.1.0-1.

Dockerfile Outdated
# Change the default user to bldocker from root
USER bldocker

LABEL maintainer="Helena Winata <[email protected]>" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to update the maintainer as well since the yaml was updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated and retested. Ready to merge?

Copy link

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorelfitzgibbon It looks like we're missing the auto-build github action? Can you check the template and add any missing files?

Copy link

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll leave the final approval to @yashpatel6.

metadata.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to add image_name in metadata.yaml for the auto-building action to name the image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashpatel6, done.

Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sorelfitzgibbon sorelfitzgibbon merged commit ebceb66 into main Jun 27, 2023
@sorelfitzgibbon sorelfitzgibbon deleted the sfitz-update-to-v2.31.0 branch June 27, 2023 18:55
@tyamaguchi-ucla
Copy link

@sorelfitzgibbon can you also put the image here /hot/software/image/docker-BEDtools?

.
└── Docker
    └── release
        └── bedtools_2.29.2.tar.gz

@sorelfitzgibbon
Copy link
Contributor Author

sorelfitzgibbon commented Jun 28, 2023

@tyamaguchi-ucla, boutrosuser/group doesn't have write permission:

drwxr-sr-x. 2 yashpatel boutrosuser 16384 Sep 26 2022 /hot/software/image/docker-BEDtools/Docker/release

@yashpatel6
Copy link
Contributor

I've updated the permissions now.

Also, on a side note, since this isn't automated for packages, we'll want to add a function to the BL util similar to getPipeline to get a package and save it to the cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants