This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Updated panel login page #20
Open
danielguoo
wants to merge
7
commits into
master
Choose a base branch
from
Daniel/login
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@danielguoo please resolve your merge conflicts with master! Git Town is great at making this easy 😄 |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
========================================
+ Coverage 62.2% 63.9% +1.7%
========================================
Files 12 12
Lines 127 133 +6
Branches 15 15
========================================
+ Hits 79 85 +6
Misses 48 48
Continue to review full report at Codecov.
|
nathanmsmith
previously requested changes
Mar 16, 2018
@@ -13,7 +13,10 @@ | |||
"postrewrite": "yarnhook" | |||
}, | |||
"lint-staged": { | |||
"*.{js,ts,tsx,json,css,scss,md}": ["prettier --write", "git add"] | |||
"*.{js,ts,tsx,json,css,scss,md}": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm these look like style errors. Can you run prettier on package.json?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Purpose
#1
Approach
Created new login page according to figma design.
Learning
Learning glamarous.
Screenshot(s)
Checklist
master
without error.Platform
Operating System: Windows 10 WSL (Ubuntu 16.04)
Node Version: 9.5.0
Further Comments