Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Updated panel login page #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Updated panel login page #20

wants to merge 7 commits into from

Conversation

danielguoo
Copy link

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

#1

Approach

Created new login page according to figma design.

Learning

Learning glamarous.

Screenshot(s)

image

Checklist

  • My branch follows the branch naming scheme of UCLA Radio, and can merge into master without error.
  • My code follows the code style of this project, and I have linted it to confirm this.
  • I have added tests that prove my fix is effective or that my feature works.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • All new and existing tests passed.

Platform

Operating System: Windows 10 WSL (Ubuntu 16.04)
Node Version: 9.5.0

Further Comments

@nathanmsmith
Copy link
Member

@danielguoo please resolve your merge conflicts with master! Git Town is great at making this easy 😄

@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #20 into master will increase coverage by 1.7%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #20     +/-   ##
========================================
+ Coverage    62.2%   63.9%   +1.7%     
========================================
  Files          12      12             
  Lines         127     133      +6     
  Branches       15      15             
========================================
+ Hits           79      85      +6     
  Misses         48      48
Impacted Files Coverage Δ
src/authentication/Login/Login.tsx 100% <ø> (ø) ⬆️
src/Background/Background.tsx 92% <ø> (ø) ⬆️
src/authentication/Login/LoginHeader.tsx 100% <100%> (ø) ⬆️
src/authentication/Login/LoginForm.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f664618...2d70ff6. Read the comment docs.

@@ -13,7 +13,10 @@
"postrewrite": "yarnhook"
},
"lint-staged": {
"*.{js,ts,tsx,json,css,scss,md}": ["prettier --write", "git add"]
"*.{js,ts,tsx,json,css,scss,md}": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm these look like style errors. Can you run prettier on package.json?

src/authentication/Login/LoginForm.tsx Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants