Be able to bind statefulsets to the host network #51

angel9484 · 2020-06-14T17:21:52Z

when the client is outside of kubernetes cluster and you cannot put a proxy between client and redis-cluster-operator we needed to change code to bind the stateful to host dedicated nodes.
This change make it configurable

…when you need to access from outside k8s without a proxy)

polefishu

@angel9484 Thanks for your interest on the redis-cluster-operator!
The redis exporter container also need to set the port HostPort.

sravyav · 2020-08-10T20:19:56Z

is it possible choose different port for redis deployment. we are planning to use multiple redis clusters and setting host network true requires lot of nodes. So, we are planning to choose different port for each redis cluster.

angel9484 · 2020-08-13T14:43:10Z

is it possible choose different port for redis deployment. we are planning to use multiple redis clusters and setting host network true requires lot of nodes. So, we are planning to choose different port for each redis cluster.

that's a great idea!, I had no time to finish this PR but my company liked your suggestion so I will try to work on this asap 👍

angel9484 · 2020-08-13T14:43:36Z

@angel9484 Thanks for your interest on the redis-cluster-operator!
The redis exporter container also need to set the port HostPort.

gotcha! I hope to work on this soon :)

angel9484 · 2020-08-13T15:13:36Z

@angel9484 Thanks for your interest on the redis-cluster-operator!
The redis exporter container also need to set the port HostPort.

@polefishu why to expose the exporter with a host port? in this case if you have a collector that get metrics and push it to (per example) prometheus, I can do it but i think for the case of the exporter is not needed, what do you think?

Thanks!!

set port to use in redis-server run

…nd_gossip_in_redis make configurable the port in all places.

angel9484 · 2020-08-14T20:06:41Z

is it possible choose different port for redis deployment. we are planning to use multiple redis clusters and setting host network true requires lot of nodes. So, we are planning to choose different port for each redis cluster.

@sravyav I've updated this PR to include the posibility to configure a port in the CR.
This has a limitation. A cluster only can have the same port maped to the hostport so if you need 6 nodes of redis, you will need a set of 6 dedicated nodes in kubernetes, but you can have a very huge 6 kubernetes workers that can allocate a lot of redis clusters (each cluster with a different port).
This limitation is due I have not all the architecture knowledge of this project and maybe needs harder architectural changes. But is a tiny good step :)

polefishu · 2020-09-21T10:15:46Z

is it possible choose different port for redis deployment. we are planning to use multiple redis clusters and setting host network true requires lot of nodes. So, we are planning to choose different port for each redis cluster.

@sravyav I've updated this PR to include the posibility to configure a port in the CR.
This has a limitation. A cluster only can have the same port maped to the hostport so if you need 6 nodes of redis, you will need a set of 6 dedicated nodes in kubernetes, but you can have a very huge 6 kubernetes workers that can allocate a lot of redis clusters (each cluster with a different port).
This limitation is due I have not all the architecture knowledge of this project and maybe needs harder architectural changes. But is a tiny good step :)

@angel9484 Thanks for the contribution. If we create a cluster with 3 masters and 3 slaves, this limitation requires us to distribute each redis to a different kubernetes nodes, this means we need at least 6 kubernetes nodes with free resources.
We need to set node affinity to ensure that all redis cannot be assigned to the same node.

polefishu · 2020-09-21T10:22:23Z

@angel9484 Thanks for your interest on the redis-cluster-operator!
The redis exporter container also need to set the port HostPort.

@polefishu why to expose the exporter with a host port? in this case if you have a collector that get metrics and push it to (per example) prometheus, I can do it but i think for the case of the exporter is not needed, what do you think?

Thanks!!

Exporter and redis share the same network namespace.

salla2 · 2020-10-02T15:32:40Z

@angel9484 is there any way we can connect to redis cluster exposing externally? we tried creating type LoadBalancer on service and trying to reach redis cluster from outside k8s cluster. Problem is it's connecting to lb and while adding the key its redirecting pod IP and saying it cant reachable because of this we can't achieve redis accessing externally. Any thoughts on how to fix it pls?
redis-cli -c -h nlb-endpoint.amazonaws.com -p 6379 a25cb6a74c9554926a019b274debedd0-fbe152a25a4b2c5a.elb.us-east-1.amazonaws.com:6379> set saty true -> Redirected to slot [7889] located at 10.42.24.254:6379 Could not connect to Redis at 10.42.24.254:6379: Network is unreachable Could not connect to Redis at 10.42.24.254:6379: Network is unreachable (15.42s)

angel9484 · 2021-02-21T17:14:47Z

@angel9484 Thanks for your interest on the redis-cluster-operator!
The redis exporter container also need to set the port HostPort.

@polefishu why to expose the exporter with a host port? in this case if you have a collector that get metrics and push it to (per example) prometheus, I can do it but i think for the case of the exporter is not needed, what do you think?
Thanks!!

Exporter and redis share the same network namespace.

Hi @polefishu !
Sorry for the big delay... :)
I've updated the PR with your recommendations and also changed some scripts that used the "default port ("no -p option per example) to work with the one configured.

Thanks!

…nd_gossip_in_redis configure more port options and monitor port in hostnetwork with hostport

…urable_port_and_gossip_in_redis # Conflicts: # pkg/apis/redis/v1alpha1/distributedrediscluster_types.go # pkg/resources/services/service.go

…nd_gossip_in_redis Feature/make configurable port and gossip in redis

angel9484

finished merging

angel9484 · 2021-02-21T17:28:17Z

@angel9484 is there any way we can connect to redis cluster exposing externally? we tried creating type LoadBalancer on service and trying to reach redis cluster from outside k8s cluster. Problem is it's connecting to lb and while adding the key its redirecting pod IP and saying it cant reachable because of this we can't achieve redis accessing externally. Any thoughts on how to fix it pls?
redis-cli -c -h nlb-endpoint.amazonaws.com -p 6379 a25cb6a74c9554926a019b274debedd0-fbe152a25a4b2c5a.elb.us-east-1.amazonaws.com:6379> set saty true -> Redirected to slot [7889] located at 10.42.24.254:6379 Could not connect to Redis at 10.42.24.254:6379: Network is unreachable Could not connect to Redis at 10.42.24.254:6379: Network is unreachable (15.42s)

Hi @salla2
redis works with node discovery. this means that if you put a LB or a dns above the redis you will only use this LB or DNS for the first time, then redis will return to the client all the ip's (advertised) and ports. This is the motivation of this PR. to let a LB beign configured with hostports and use the host network. So with this feature you will be able to configure a LB and access externaly without the usage of a proxy (with the lot of drawbacks the proxies has) with the only drawback that you are "reserving" fixed ports on the kubernetes cluster

…nd_gossip_in_redis Feature/make configurable port and gossip in redis

…nd_gossip_in_redis delete again check of min number of replicas as original code has

smallersoup · 2021-04-12T08:52:13Z

Hi，Why hasn't this PR been merged for so long?

…ckup_and_restore use directly osm

fyankee · 2023-03-24T09:13:30Z

Why hasn't this PR been merged？ @polefishu @angel9484 @fabrinator

nangelhotelbeds added 3 commits June 14, 2020 18:48

make operator able to chose when a cluster is bind to the hosts (ex. …

0781bfb

…when you need to access from outside k8s without a proxy)

export variable and remove unnecessary condition of nil bool

09ad959

remove typo underscore.

defa632

polefishu reviewed Jul 10, 2020

View reviewed changes

make configurable the port in all places but in the redis conf file.

a931b68

nangelhotelbeds and others added 4 commits August 13, 2020 21:03

remove gossip as is always 10000 + clientPort

227c7de

set port to use in redis-server run

revert stringarg port configuration

4babaf1

deleted done todo

3dbc161

Merge pull request #1 from angel9484/feature/make_configurable_port_a…

9e326c7

…nd_gossip_in_redis make configurable the port in all places.

angel9484 mentioned this pull request Aug 14, 2020

Add Support to Set Hostnetwork True and Choose Different Ports #58

Open

nangelhotelbeds added 4 commits February 21, 2021 17:47

spread port for all operations using cli or -h

1769dfb

remove default port

54d0833

spread port from arguments the port.

9336f4d

expose also monitor prometheus port when using hostnetwork.

7f6f520

angel9484 and others added 3 commits February 21, 2021 18:16

Merge pull request #2 from angel9484/feature/make_configurable_port_a…

b515195

…nd_gossip_in_redis configure more port options and monitor port in hostnetwork with hostport

Merge remote-tracking branch 'forked/master' into feature/make_config…

5c0899c

…urable_port_and_gossip_in_redis # Conflicts: # pkg/apis/redis/v1alpha1/distributedrediscluster_types.go # pkg/resources/services/service.go

Merge pull request #3 from angel9484/feature/make_configurable_port_a…

f34d70e

…nd_gossip_in_redis Feature/make configurable port and gossip in redis

angel9484 commented Feb 21, 2021

View reviewed changes

nangelhotelbeds added 2 commits February 22, 2021 15:45

remove -p from non redis-cli command

4731615

remove -p from non redis-cli command

b0f468c

Merge pull request #4 from angel9484/feature/make_configurable_port_a…

792deab

…nd_gossip_in_redis Feature/make configurable port and gossip in redis

fabrinator previously approved these changes Mar 23, 2021

View reviewed changes

nangelhotelbeds and others added 2 commits March 24, 2021 08:12

delete again check of min number of replicas as original code has

a82e83c

Merge pull request #5 from angel9484/feature/make_configurable_port_a…

20d0d60

…nd_gossip_in_redis delete again check of min number of replicas as original code has

angel9484 dismissed fabrinator’s stale review via 20d0d60 March 24, 2021 07:14

nangelhotelbeds and others added 3 commits April 11, 2022 07:59

use directly osm

ec08b99

restore deleted const

5bc679d

Merge pull request #6 from angel9484/feature/native_s3_support_for_ba…

b9947ef

…ckup_and_restore use directly osm

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Be able to bind statefulsets to the host network #51

Be able to bind statefulsets to the host network #51

angel9484 commented Jun 14, 2020

polefishu left a comment

sravyav commented Aug 10, 2020

angel9484 commented Aug 13, 2020

angel9484 commented Aug 13, 2020

angel9484 commented Aug 13, 2020

angel9484 commented Aug 14, 2020 •

edited

Loading

polefishu commented Sep 21, 2020

polefishu commented Sep 21, 2020

salla2 commented Oct 2, 2020

angel9484 commented Feb 21, 2021

angel9484 left a comment

angel9484 commented Feb 21, 2021

smallersoup commented Apr 12, 2021

fyankee commented Mar 24, 2023

Be able to bind statefulsets to the host network #51

Are you sure you want to change the base?

Be able to bind statefulsets to the host network #51

Conversation

angel9484 commented Jun 14, 2020

polefishu left a comment

Choose a reason for hiding this comment

sravyav commented Aug 10, 2020

angel9484 commented Aug 13, 2020

angel9484 commented Aug 13, 2020

angel9484 commented Aug 13, 2020

angel9484 commented Aug 14, 2020 • edited Loading

polefishu commented Sep 21, 2020

polefishu commented Sep 21, 2020

salla2 commented Oct 2, 2020

angel9484 commented Feb 21, 2021

angel9484 left a comment

Choose a reason for hiding this comment

angel9484 commented Feb 21, 2021

smallersoup commented Apr 12, 2021

fyankee commented Mar 24, 2023

angel9484 commented Aug 14, 2020 •

edited

Loading