-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build meson support #1242
base: master
Are you sure you want to change the base?
Build meson support #1242
Conversation
I'm not sure we want to add a second build system into the library... |
Sorry I realized that I did not add much to my PR description. My idea with this PR was to provide the possibility to use openjpeg as a subproject of another meson project (gst-build). But as you can see, I did not touch anything in CMake and we can have also the power and flexiility of the trendy Meson. |
openjpeg is insufficiently maintained (by me in particular :-)), so adding more stuff that could rot easily (as I won't use it personnally) is not super compelling. You might want to raise the issue on the openjpeg mailing list and see if it raises interest from other stakeholders. by the way the change in libtiff should likely be reverted. libtiff has an upstream (https://gitlab.com/libtiff/libtiff), and openjpeg should not modify it, unless resynchronizing with that upstream |
79c7c56
to
8514d33
Compare
No problem I will drop the I understand your point regarding the support of 2 build system :) I just wanted to let you know first of the existence of this port. |
03f119e
to
2892884
Compare
Build support: - thirdparties(z, tiff, png, cms2) - jp2 - jpip - jpwl - mj2 - jp3d
2892884
to
fde6878
Compare
Only necessary in the case of build_viewer option
Porting openjpeg to Meson would allow to delete the thirdparty directory completely. Meson has a subproject mechanism made exactly for that use-case. zlib, png, tiff are already available in meson ports (wrapdb) and lcms2 could easily be added too. |
Openjpeg is used by GStreamer to support jpeg2000 and as gst-build provides a very easy way to build gstreamer and its depencies using Meson, here is a bunch of commits to add this support, without any changes to the existing CMake build system.