Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #695 MQ Encode: ensure that bp pointer never points to uninitialized memory #708

Merged
merged 2 commits into from
Apr 18, 2016
Merged

Conversation

boxerab
Copy link
Contributor

@boxerab boxerab commented Jan 29, 2016

fixes #695

@boxerab boxerab changed the title issue #695 MQ Encode: ensure that bp pointer never points to uninitia… issue #695 MQ Encode: ensure that bp pointer never points to uninitialized memory Jan 29, 2016
@boxerab
Copy link
Contributor Author

boxerab commented Jan 29, 2016

This has to fix the uninitialized memory issue. What I find surprising is that such a critical bug has existed for so long ( > 5 years )

@mayeut
Copy link
Collaborator

mayeut commented Jan 30, 2016

@boxerab, Unfortunately, this doesn't help: http://my.cdash.org/viewDynamicAnalysisFile.php?id=3438342

@boxerab
Copy link
Contributor Author

boxerab commented Mar 31, 2016

The patch fixes a definite bug: there may be other similar bugs in the MQ coder that continue causing a valgrind error.

@detonin detonin merged commit e1a93d9 into uclouvain:master Apr 18, 2016
@detonin
Copy link
Contributor

detonin commented Apr 18, 2016

@boxerab @mayeut does this fix #612 ?

@julienmalik
Copy link
Collaborator

I'm currently looking into refreshing the dashboard submissions from CS, which are currently only noise since the GitHub migration, because they are still looking for updates from svn :)

Seeing all the work achieve with Travis, I will remove most of them, but try to setup again the valgrind build where we should see the effect of this patch.

@boxerab
Copy link
Contributor Author

boxerab commented Apr 18, 2016

Unfortunately, I don't have time to look into this at the moment.

@julienmalik
Copy link
Collaborator

@boxerab boxerab deleted the issue_695 branch October 19, 2016 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQ Coder encode: Conditional jump or move depends on uninitialised value(s)
4 participants