Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 543: Designate ObservablePattern a subclass of Pattern, adding namespace import #560

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Issue 543: Designate ObservablePattern a subclass of Pattern, adding namespace import #560

merged 2 commits into from
Nov 22, 2023

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Nov 9, 2023 •
edited
Loading

This Pull Request resolves all requirements of Issue #543 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (65cc8a8)
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable as submodule (6e89872)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (N/A) - bugfix proposal

@ajnelson-nist
Designate ObservablePattern a subclass of Pattern, adding namespace i…
d5ad31f 
…mport

This patch also has the Observable namespace import the Pattern
namespace, to attain first access to the Pattern class.

No effects were observed on Make-managed files.

References:
* #543

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Nov 9, 2023
@ajnelson-nist ajnelson-nist mentioned this pull request Nov 9, 2023
Closed
10 tasks
@ajnelson-nist ajnelson-nist linked an issue Nov 9, 2023 that may be closed by this pull request
Possible bug - ObservablePattern is not a subclass of Pattern #543
Closed
10 tasks
@ajnelson-nist
Revert direct Pattern namespace import
885acb5 
The previous patch included a direct Pattern namespace import.  This
turns out to not be necessary because the Pattern namespace is already
in the transitive `owl:imports` closure, via the Action namespace.
Hence, the `Pattern` class is already available for `ObservablePattern`.

I realized this when I noticed the `catalog-v001.xml` file didn't
require an update from adding the direct import.

References:
* #543

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist marked this pull request as ready for review November 20, 2023 21:35
@ajnelson-nist ajnelson-nist requested a review from a team November 20, 2023 21:35
@ajnelson-nist
Copy link
Contributor Author

Any member of @ucoProject/maintainers-uco may feel free to merge this PR. I believe it is bugfix-grade, and if you agree, please merge.

@plbt5 plbt5 merged commit 0c2240c into develop-2.0.0 Nov 22, 2023
1 check passed
@plbt5 plbt5 deleted the BugFix-Issue-543 branch November 22, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
bug Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

Possible bug - ObservablePattern is not a subclass of Pattern
2 participants
@ajnelson-nist @plbt5