Fixed issue where undoing empty mentions or non-existent users caused…

.changeset/shiny-beers-remember.md

@@ -0,0 +1,5 @@
+---
+"@udecode/plate-mention": patch
+---
+
+Fixed issue where undoing empty mentions or non-existent users caused system crashes.

apps/www/src/registry/default/plate-ui/combobox.tsx

@@ -21,7 +21,10 @@ import {
   useEventEditorSelectors,
   usePlateSelectors,
 } from '@udecode/plate-common';
-import { createVirtualRef } from '@udecode/plate-floating';
+import {
+  createVirtualRef,
+  getBoundingClientRect,
+} from '@udecode/plate-floating';
 
 export const ComboboxItem = withRef<'div', ComboboxContentItemProps>(
   ({ combobox, index, item, onRenderItem, className, ...rest }, ref) => {
@@ -59,11 +62,13 @@ export function ComboboxContent(props: ComboboxContentProps) {
   const state = useComboboxContentState({ items, combobox });
   const { menuProps, targetRange } = useComboboxContent(state);
 
+  const virtualRef = createVirtualRef(editor, targetRange ?? undefined, {
+    fallbackRect: getBoundingClientRect(editor, editor.selection!),
+  });
+
   return (
     <Popover.Root open>
-      <Popover.PopoverAnchor
-        virtualRef={createVirtualRef(editor, targetRange ?? undefined)}
-      />
+      <Popover.PopoverAnchor virtualRef={virtualRef} />
 
       <Popover.Portal container={portalElement}>
         <Popover.Content

packages/mention/src/handlers/mentionOnKeyDownHandler.ts

@@ -1,4 +1,9 @@
-import { isHotkey, PlateEditor, Value } from '@udecode/plate-common';
+import {
+  isHotkey,
+  moveSelection,
+  PlateEditor,
+  Value,
+} from '@udecode/plate-common';
 
 import { findMentionInput } from '../queries/index';
 import { removeMentionInput } from '../transforms/index';
@@ -17,6 +22,7 @@ export const mentionOnKeyDownHandler: <V extends Value>(
       if (currentMentionInput) {
         event.preventDefault();
         removeMentionInput(editor, currentMentionInput[1]);
+        moveSelection(editor, { unit: 'word' });
         return true;
       }
       return false;

packages/mention/src/transforms/removeMentionInput.ts

@@ -1,8 +1,9 @@
 import {
+  EText,
   getNode,
-  insertText,
+  getNodeString,
   PlateEditor,
-  unwrapNodes,
+  replaceNode,
   Value,
   withoutNormalizing,
 } from '@udecode/plate-common';
@@ -20,10 +21,10 @@ export const removeMentionInput = <V extends Value>(
 
     const { trigger } = node;
 
-    insertText(editor, trigger, {
-      at: { path: [...path, 0], offset: 0 },
-    });
-    unwrapNodes(editor, {
+    const text = getNodeString(node);
+
+    replaceNode(editor, {
       at: path,
+      nodes: { text: `${trigger}${text}` } as EText<V>,
     });
   });

packages/mention/src/withMention.ts

@@ -5,6 +5,7 @@ import {
   getPlugin,
   getPointBefore,
   getRange,
+  moveSelection,
   PlateEditor,
   setSelection,
   TNode,
@@ -81,7 +82,8 @@ export const withMention = <
   editor.deleteBackward = (unit) => {
     const currentMentionInput = findMentionInput(editor);
     if (currentMentionInput && getNodeString(currentMentionInput[0]) === '') {
-      return removeMentionInput(editor, currentMentionInput[1]);
+      removeMentionInput(editor, currentMentionInput[1]);
+      return moveSelection(editor, { unit: 'word' });
     }
 
     deleteBackward(unit);
@@ -151,6 +153,7 @@ export const withMention = <
 
       if (previousMentionInputPath && !currentMentionInputPath) {
         removeMentionInput(editor, previousMentionInputPath);
+        moveSelection(editor, { unit: 'word' });
       }
 
       if (currentMentionInputPath) {