Table actions #68
Merged
Table actions #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindw
commented
Feb 5, 2020
| @@ -7,6 +7,7 @@ import { RenderElementTableOptions, TableType } from './types'; | |||
| const StyledTable = styled.table` | |||
| margin: 10px 0; | |||
| border-collapse: collapse; | |||
| width: 100%; | |||
There was a problem hiding this comment.
Full table width fits better as long as we can't position other elements next to the table anyway. Maybe this could be configurable?
There was a problem hiding this comment.
Yes resizing the table, the columns and the rows would be nice in the future.
eivindw
commented
Feb 5, 2020
| @@ -3,12 +3,33 @@ import { boolean } from '@storybook/addon-knobs'; | |||
| import { createEditor } from 'slate'; | |||
| import { withHistory } from 'slate-history'; | |||
| import { Slate, withReact } from 'slate-react'; | |||
|
|
|||
| import { | |||
| BorderAll, | |||
There was a problem hiding this comment.
Random choice of icons for the example buttons..
zbeyens
reviewed
Feb 5, 2020
| <HeadingToolbar> | ||
| <ToolbarMark format={MARK_BOLD} icon={<FormatBold />} /> | ||
| <ToolbarTable action={insertTable} icon={<BorderAll />} /> | ||
| <ToolbarTable action={deleteTable} icon={<BorderClear />} /> |
There was a problem hiding this comment.
In the future we can add a floating delete button.
GitBook example (in the sidebar):
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some actions and example buttons for table editing: