Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: check props.clientRect before creating ReactRenderer #4138

Merged
merged 5 commits into from
Jul 7, 2023
Merged

fixed: check props.clientRect before creating ReactRenderer #4138

merged 5 commits into from
Jul 7, 2023

Conversation

hariacharya80
Copy link
Contributor

@hariacharya80 hariacharya80 commented Jun 19, 2023

Please describe your changes

Moved validation to top of the onStart function.

How did you accomplish your changes

[add a detailed description of how you accomplished your changes here]

Moved Validation:

 if (!props.clientRect) {
          return
        }

to the first line of onStart, see commits.

Remarks

Reduce bugs risk for Chinese users

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

closes #4137

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 74074a1
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64990f37a6f5a20008c76031
😎 Deploy Preview https://deploy-preview-4138--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch
Copy link
Contributor

bdbch commented Jun 20, 2023

Thanks - good find.

@bdbch
Copy link
Contributor

bdbch commented Jun 25, 2023

Could you fix those issues we have with the PR? @hariacharya80

@bdbch bdbch linked an issue Jun 25, 2023 that may be closed by this pull request
@bdbch bdbch changed the title Fixed #4137 fix(suggestion): check props.clientRect before creating ReactRenderer Jun 25, 2023
@hariacharya80
Copy link
Contributor Author

Could you fix those issues we have with the PR? @hariacharya80

Ohh sorry for not seeing this comment, Ok let me get that just few mins..

@hariacharya80
Copy link
Contributor Author

@bdbch Done!

@hariacharya80 hariacharya80 changed the title fix(suggestion): check props.clientRect before creating ReactRenderer fixed: check props.clientRect before creating ReactRenderer Jun 28, 2023
@bdbch bdbch merged commit d710846 into ueberdosis:develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Commands
2 participants