Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cut Command & Position Mapping for insertContentAt #4141

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Jun 20, 2023

Please describe your changes

This PR adds two new functionalities:

  1. A new cut command to move content from one place to another
  2. Position mapping for insertContentAt to take positional changes on the transaction and maps it to the given position

How did you accomplish your changes

See changed files

How have you tested your changes

I used a local demo to test my changes

How can we verify your changes

Create a local demo with a button that cuts content from one position to another and test it.

Remarks

This may introduce a breaking change due to some people maybe doing the position mapping manually already. This is something for 2.1.0.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

@bdbch bdbch self-assigned this Jun 20, 2023
@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 1dad098
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64a7f42eea8a31000815a7de
😎 Deploy Preview https://deploy-preview-4141--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch marked this pull request as ready for review June 20, 2023 23:46
@bdbch bdbch mentioned this pull request Jun 21, 2023
5 tasks
@bdbch bdbch merged commit 7e38c0f into develop Jul 7, 2023
11 of 13 checks passed
@bdbch bdbch deleted the feature/cut branch July 7, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants