Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fifo queue support #120

Merged
merged 10 commits into from
Jun 7, 2017
Merged

Add fifo queue support #120

merged 10 commits into from
Jun 7, 2017

Conversation

mumia
Copy link
Contributor

@mumia mumia commented Mar 27, 2017

Adds support for creating/destroying/publishing/receiving messages to and from an AWS FIFO Queue

@tlfbrito
Copy link

@kmfk Can you review this implementation please?

@k-k
Copy link
Contributor

k-k commented Jun 7, 2017

@mumia I was a little quick to merge that last PR (#117), I just resolved the conflict I created by doing so

@scrutinizer-notifier
Copy link

The inspection completed: 3 updated code elements

@k-k k-k merged commit b8bdc60 into uecode:master Jun 7, 2017
This was referenced Jun 7, 2017
@francoispluchino
Copy link
Contributor

@mumia Thanks for your work, however, there is a little bug with the push notification and FIFO queue. You can see the PR #124 for the fix.

@mumia
Copy link
Contributor Author

mumia commented Jul 12, 2017

@francoispluchino It seems I mislead you with my implementation.
SNS topic subscription is not currently support by AWS for FIFO Queues.
Check the "Compatibility" section on: http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html

I will write a fix for my PR removing the push notification support on fifo queues.

@francoispluchino
Copy link
Contributor

Indeed, the doc isn't updated regarding the regions available, but SNS is still not available with SQS FIFO. Thanks for your precision.

On the other hand, my PR fixes the error 400 Invalid parameter: Topic Name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants