Update composer.json to include version 4.0 for symfony libraries #137
Conversation
nfabre
commented
Dec 1, 2017
nfabre
commented
- Update composer.json
- Add command to services.yml to be able to use it ;)
src/Resources/config/parameters.yml
Outdated
| uecode_qpush.build_command.class: Uecode\Bundle\QPushBundle\Command\QueueBuildCommand | ||
| uecode_qpush.destroy_command.class: Uecode\Bundle\QPushBundle\Command\QueueDestroyCommand | ||
| uecode_qpush.publish_command.class: Uecode\Bundle\QPushBundle\Command\QueuePublishCommand | ||
| uecode_qpush.receive_command.class: Uecode\Bundle\QPushBundle\Command\QueueReceiveCommand |
There was a problem hiding this comment.
Since Symfony 3.0 the best practices recommend to remove all *.class parameters. See the explanations in the issue symfony/symfony#11881. So, it may be wiser not to add new *.class parameters, but to retain old parameters for backward compatibility.
There was a problem hiding this comment.
I missed that. I fixed it.
src/Resources/config/parameters.yml
Outdated
| uecode_qpush.provider.aws: Uecode\Bundle\QPushBundle\Provider\AwsProvider | ||
| uecode_qpush.provider.ironmq: Uecode\Bundle\QPushBundle\Provider\IronMqProvider | ||
| uecode_qpush.provider.sync: Uecode\Bundle\QPushBundle\Provider\SyncProvider | ||
| uecode_qpush.provider.custom: Uecode\Bundle\QPushBundle\Provider\CustomProvider | ||
| uecode_qpush.provider.file: Uecode\Bundle\QPushBundle\Provider\FileProvider | ||
| uecode_qpush.provider.file: Uecode\Bundle\QPushBundle\Provider\FileProvider |
There was a problem hiding this comment.
I forgot to tell you that the file must end with a newline.
…d commands to services.yml & remove all *.class
|
Any idea when this PR will be available ? @nfabre @francoispluchino |
|
Yes, we would need it too. :-) |
|
@RomulusED69 I don't have access to the repository with the write permissions, so I cannot do much... But I also need this PR to pass a project in 4.0. |
|
ping @kmfk |
|
I think this bundle will be deprecated with the new Symfony's Messenger composant. |
|
I hope not, because IronMQ is not suppported neither by the new component, neither by the bridge, neither by I've just opened an issue for it. php-enqueue/enqueue-dev#415 |
|
Hello. So, reviewing the PRs, the issues with the broken builds etc, it made most sense to drop support for php 5.4 and 5.5 - was going to do this in a new major version (including this PR). However, I haven't had the opportunity to work in a symfony project in a few years now and have done a pretty poor job keeping up on this repo. If I were to transfer this to a new org, anyone here interested in helping to maintain it? |
|
The inspection completed: No new issues |
|
Is there a particular reason to not file a pull request or feature request with symfony/messenger to support IronMQ @tristanbes ? |
|
As I understand it, the messenger component use the enqueue bundle and library and it’s not supported yet. I’ve opened an issue there but we got some project using this library
Envoyé de mon iPhone
… Le 28 mars 2018 à 21:05, Aaron Scherer ***@***.***> a écrit :
Is there a particular reason to not file a pull request or feature request with symfony/messenger to support IronMQ @tristanbes ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@nfabre @tristanbes I tagged v3.0 |
|
@kmfk The tag |
|
@francoispluchino Fixed. Looks like Packagist started validating the license text in the composer.json and mine was missing a hyphen. |
|
Great! But I just saw an another problem: why this constraint for |
|
Huh. I saw that while fixing a merge conflict from another PR, but noticed that the original commit in this PR had also left it that way. I'm guessing that needs to be bumped as well? |
|
Yes. |
