Improvements for FileProvider #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP's mkdir() does not create parent dirs, but Filesystem() does
|
The inspection completed: No new issues |
|
@czenker - thanks for the contribution! Looks good to me, is ready to merge? |
|
@kmfk Yes - works for me :) I didn't test the doc rendering, but the changes there are simple enough to not break. |
|
@czenker thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for the FileProvider was not linked in the official documentation.
Secondly: using the file provider failed when not calling
php app/console uecode:qpush:buildbefore. Using the methods of the Filesystem class is more consistent with the remainder of the code of the FileProvider and also creates parent directories when they are missing.