Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readable stream #112

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Support readable stream #112

merged 3 commits into from
Jul 23, 2020

Conversation

m77so
Copy link
Collaborator

@m77so m77so commented Jul 9, 2020

@uetchy
Copy link
Owner

uetchy commented Jul 19, 2020

Thank you for the patch!
I tried to test your PR on my machine but ended up seeing 403 error.
Are you sure that you can successfully download a video?

@m77so
Copy link
Collaborator Author

m77so commented Jul 23, 2020

Yes, it works on my local machine and GCP cloud shell.

This is my test execution on GCP cloud shell.

myemailaddress@cloudshell:~ (testprj)$ git clone https://github.com/m77so/niconico.git
Cloning into 'niconico'...
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 924 (delta 0), reused 2 (delta 0), pack-reused 918
Receiving objects: 100% (924/924), 856.45 KiB | 778.00 KiB/s, done.
Resolving deltas: 100% (609/609), done.
myemailaddress@cloudshell:~ (testprj)$ cd niconico/
myemailaddress@cloudshell:~/niconico (testprj)$ yarn
yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 17.04s.
myemailaddress@cloudshell:~/niconico (testprj)$ [email protected] NICONICO_PASSWORD=hogehoge yarn test
yarn run v1.22.4
$ jest --coverage
(node:1268) ExperimentalWarning: The fs.promises API is experimental
 PASS  tests/nicovideo.test.ts (33.043s)
 PASS  tests/niconico.test.ts
--------------|---------|----------|---------|---------|-------------------
File          | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------|---------|----------|---------|---------|-------------------
All files     |   98.18 |     87.5 |     100 |   98.15 |                  
 niconico.ts  |     100 |      100 |     100 |     100 |                  
 nicovideo.ts |   97.62 |    83.33 |     100 |   97.56 | 42               
--------------|---------|----------|---------|---------|-------------------

Test Suites: 2 passed, 2 total
Tests:       8 passed, 8 total
Snapshots:   0 total
Time:        34.556s
Ran all test suites.
Done in 35.44s.
myemailaddress@cloudshell:~/niconico (testprj)$ ls
coverage  examples        LICENSE       package.json  src    tsconfig.json  yarn.lock
docs      jest.config.js  node_modules  README.md     tests  tslint.json    【ゆめにっき】クリプト・オブ・ザ・モノクロダンサー.mp4
myemailaddress@cloudshell:~/niconico (testprj)$ node -v
v10.14.2

@uetchy uetchy merged commit 6f26f2d into uetchy:master Jul 23, 2020
@uetchy
Copy link
Owner

uetchy commented Jul 23, 2020

Merged🚀

@uetchy
Copy link
Owner

uetchy commented Jul 23, 2020

@m77so Could you add a document for stream in README?

@m77so
Copy link
Collaborator Author

m77so commented Jul 24, 2020

Sure, I added a document on #114 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants