Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chgres_cube for fractional grids #873

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Nov 20, 2023

DESCRIPTION OF CHANGES:

Update chgres_cube for fractional (partial land/non-land) grids. Update the format of the surface coldstart file (called v2). These changes are designed to be backwards compatible with the forecast model.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). Done using 45ca85a.
  • Compile branch on Hera using GNU. Done using 45ca85a.
  • Compile branch in 'Debug' mode on WCOSS2. Done using 45ca85a
  • Run unit tests locally on any Tier 1 machine. Done on dogwood using 45ca85a. All passed.
  • Run relevant consistency tests locally on all Tier 1 machine. Done using 45ca85a. All chgres_cube tests failed as expected. Most grid_gen tests failed as expected. For details, see notes below.

Describe any additional tests performed.

DEPENDENCIES:

NOAA-EMC/fv3atm#698
ufs-community/ufs-weather-model#2005

DOCUMENTATION:

N/A

ISSUE:

Fixes #123.

For non-fractional grids, the soil temperature field was
used for both land and non-land. Now points can have
both land and sea ice.

Fixes ufs-community#123.
Using the land mask array will not work with fractional grids.

Fixes ufs-community#123.
record for ice substrate temperature.

Fixes ufs-community#123
@BrianCurtis-NOAA
Copy link

@GeorgeGayno-NOAA If your FV3 PR NOAA-EMC/fv3atm#698 is ready to go, should this still be in draft form?

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review January 8, 2024 15:35
reg_tests/chgres_cube/25km.conus.gfs.grib2.sh Show resolved Hide resolved
reg_tests/chgres_cube/25km.conus.gfs.grib2.sh Show resolved Hide resolved
reg_tests/chgres_cube/c192.fv3.history.sh Show resolved Hide resolved
reg_tests/chgres_cube/c192.gfs.grib2.sh Show resolved Hide resolved
reg_tests/chgres_cube/c96.regional.sh Outdated Show resolved Hide resolved
sorc/chgres_tools.fd/check.F90 Outdated Show resolved Hide resolved
sorc/chgres_tools2.fd/CMakeLists.txt Outdated Show resolved Hide resolved
@GeorgeGayno-NOAA
Copy link
Collaborator Author

All grid_gen consistency tests failed except the c96 uniform test.

The sfc_climo_gen code was updated to always map surface fields to any point with at least some land (this is expected by updated chgres_cube). Previously, surface fields were mapped to points with at least some land only when the 'add_lake' option was used. Otherwise, surface fields were only mapped to points with 50% land.

The c96 uniform tests used the 'add_lake' option (and passed). The others did not use that option. As a result, the surface files from the remaining tests differed from the baseline (the 'grid' and 'oro' files were the same). As expected, the surface files created by the branch included additional data points at coasts. Inland, the data were the same.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

A note about the chgres_cube consistency tests.

Since the updated chgres_cube requires valid surface values at all points with at least some land, the 'fixed' data input to the tests was updated.

The c96 and c192 tests now use the '202310127' version files ('grid', 'oro' and 'sfc' files).

The RRFS 13KM and 25KM fixed files ('grid', 'oro' and 'sfc' files) were recreated using the branch. Despite several attempts, I could not get the grids to exactly match (the CRES is slightly different). However, they are very close.

The RRFS 3KM surface fixed files were updated, but the same 'grid' and 'oro' files were used.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

All chgres_cube consistency tests failed as expected.

Failures were due to:

  • The new chgres outputs a different surface coldstart file format
  • Differences in the input fixed data (new 'grid', 'oro' and 'sfc' files)
  • The new chgres outputs data for a fractional land/non-land grid.

Files from the branch tests were visualized against the baseline data. The differences I saw were consistent with the updates for this PR and did not indicate a problem with the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chgres_cube for mixed land/non-land points
3 participants