-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chgres_cube for fractional grids #873
Update chgres_cube for fractional grids #873
Conversation
For non-fractional grids, the soil temperature field was used for both land and non-land. Now points can have both land and sea ice. Fixes ufs-community#123.
fractional grid option. Fixes ufs-community#123.
'fract_grid' is true. Fixes ufs-community#123
to work better with fractional grids. Fixes ufs-community#123.
Using the land mask array will not work with fractional grids. Fixes ufs-community#123.
and non-fractional grids. Fixes ufs-community#123.
processing fractional grids. Fixes ufs-community#123
record for ice substrate temperature. Fixes ufs-community#123
fractional grid logic. Fixes ufs-community#123.
some land (fractional case). Fixes ufs-community#123
@GeorgeGayno-NOAA If your FV3 PR NOAA-EMC/fv3atm#698 is ready to go, should this still be in draft form? |
all points with at least some land. Fixes ufs-community#123.
data at all points with some land. Fixes ufs-community#123.
All The The c96 uniform tests used the 'add_lake' option (and passed). The others did not use that option. As a result, the surface files from the remaining tests differed from the baseline (the 'grid' and 'oro' files were the same). As expected, the surface files created by the branch included additional data points at coasts. Inland, the data were the same. |
A note about the Since the updated The c96 and c192 tests now use the '202310127' version files ('grid', 'oro' and 'sfc' files). The RRFS 13KM and 25KM fixed files ('grid', 'oro' and 'sfc' files) were recreated using the branch. Despite several attempts, I could not get the grids to exactly match (the CRES is slightly different). However, they are very close. The RRFS 3KM surface fixed files were updated, but the same 'grid' and 'oro' files were used. |
All Failures were due to:
Files from the branch tests were visualized against the baseline data. The differences I saw were consistent with the updates for this PR and did not indicate a problem with the branch. |
…ectory than the one used by the orion script. Fixes ufs-community#123.
DESCRIPTION OF CHANGES:
Update
chgres_cube
for fractional (partial land/non-land) grids. Update the format of the surface coldstart file (called v2). These changes are designed to be backwards compatible with the forecast model.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
chgres_cube
tests failed as expected. Mostgrid_gen
tests failed as expected. For details, see notes below.Describe any additional tests performed.
DEPENDENCIES:
NOAA-EMC/fv3atm#698
ufs-community/ufs-weather-model#2005
DOCUMENTATION:
N/A
ISSUE:
Fixes #123.