-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed stratosphere warm bias and code optimization for MERRA2 #88
fixed stratosphere warm bias and code optimization for MERRA2 #88
Conversation
Regression Testing is complete on UFS-WM PR #1815 . This PR has approval can now be merged. @dustinswales @Qingfu-Liu |
@mkavulich This PR can be merged. |
Good morning. Following up here. Can this PR please be merged? @mkavulich , @dustinswales , @Qingfu-Liu |
Apologies. I'm back from leave. I'll merge. |
Did I miss anything? Is the following question answered?
* RuiyuSun <https://github.com/RuiyuSun> * Pending
I am not familiar with this conversion. But I see the changes with the two
coefficents. What is the reason for the changes? Thanks.
Collaborator
[image: @RuiyuSun] * RuiyuSun <https://github.com/RuiyuSun> * Pending
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
Collaborator
[image: @RuiyuSun] * RuiyuSun <https://github.com/RuiyuSun> * Pending
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> I am not familiar
with this conversion. But I see the changes with the two coefficents. What
is the reason for the changes? Thanks.
…On Mon, Jul 24, 2023 at 8:44 AM Grant Firl ***@***.***> wrote:
Merged #88 <#88> into
ufs/dev.
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFOCLEPXR6ODV6LGCXIASLXRZU2FANCNFSM6AAAAAAZZ6XUEY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Ruiyu Sun, PhD
Lynker at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2097
College Park, MD 20740
***@***.*** ***@***.***>
301-683-3787
|
@
@RuiyuSun I don't see what this question is referring to? Could you recomment where in the code you're asking about? @AnningCheng-NOAA Can you respond to @RuiyuSun 's question? |
Ruiyu:
The old two coefficients are tuned from a few experiments. I switched
them back to the original ones used by Eidhammer and Thompson for
evaluation purposes. All the coefficients might be tuned in the future
when the evaluations are done.
On Mon, Jul 24, 2023 at 10:40 AM Grant Firl ***@***.***>
wrote:
… @
Did I miss anything? Is the following question answered? * RuiyuSun
https://github.com/RuiyuSun * Pending I am not familiar with this
conversion. But I see the changes with the two coefficents. What is the
reason for the changes? Thanks. Collaborator [image: @RuiyuSun
<https://github.com/RuiyuSun>] * RuiyuSun https://github.com/RuiyuSun *
Pending @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
https://github.com/AnningCheng-NOAA Collaborator [image: @RuiyuSun
<https://github.com/RuiyuSun>] * RuiyuSun https://github.com/RuiyuSun *
Pending @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
https://github.com/AnningCheng-NOAA I am not familiar with this
conversion. But I see the changes with the two coefficents. What is the
reason for the changes? Thanks.
… <#m_-3317279424459575881_>
On Mon, Jul 24, 2023 at 8:44 AM Grant Firl *@*.*> wrote: Merged #88
<#88> <#88
<#88>> into ufs/dev. —
Reply to this email directly, view it on GitHub <#88 (comment)
<#88 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKFOCLEPXR6ODV6LGCXIASLXRZU2FANCNFSM6AAAAAAZZ6XUEY
<https://github.com/notifications/unsubscribe-auth/AKFOCLEPXR6ODV6LGCXIASLXRZU2FANCNFSM6AAAAAAZZ6XUEY>
. You are receiving this because your review was requested.Message ID: @.*
>
-- Ruiyu Sun, PhD Lynker at NOAA/NWS/NCEP/EMC 5830 University Research
Ct., Rm. 2097 College Park, MD 20740 *@*.*** *@*.***> 301-683-3787
@RuiyuSun <https://github.com/RuiyuSun> I don't see what this question is
referring to? Could you recomment where in the code you're asking about?
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Can you respond
to @RuiyuSun <https://github.com/RuiyuSun> 's question?
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJRRMRHTR6FNYKOX4TXR2CMBANCNFSM6AAAAAAZZ6XUEY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I see. Thanks@AnningCheng-NOAA |
Opening this PR on behalf of @AnningCheng-NOAA. This replaces the accidentally closed one: #79. All previous reviews from #79 should still be valid.
resolved issue ufs-community/ufs-weather-model#1786