Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed stratosphere warm bias and code optimization for MERRA2 #88

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Jun 30, 2023

Opening this PR on behalf of @AnningCheng-NOAA. This replaces the accidentally closed one: #79. All previous reviews from #79 should still be valid.

resolved issue ufs-community/ufs-weather-model#1786

@zach1221
Copy link

Regression Testing is complete on UFS-WM PR #1815 . This PR has approval can now be merged. @dustinswales @Qingfu-Liu

@jkbk2004
Copy link

@mkavulich This PR can be merged.

@zach1221
Copy link

Good morning. Following up here. Can this PR please be merged? @mkavulich , @dustinswales , @Qingfu-Liu

@grantfirl
Copy link
Collaborator Author

Good morning. Following up here. Can this PR please be merged? @mkavulich , @dustinswales , @Qingfu-Liu

Apologies. I'm back from leave. I'll merge.

@grantfirl grantfirl merged commit 9b69974 into ufs-community:ufs/dev Jul 24, 2023
@RuiyuSun
Copy link
Collaborator

RuiyuSun commented Jul 24, 2023 via email

@grantfirl
Copy link
Collaborator Author

@

Did I miss anything? Is the following question answered? * RuiyuSun https://github.com/RuiyuSun * Pending I am not familiar with this conversion. But I see the changes with the two coefficents. What is the reason for the changes? Thanks. Collaborator [image: @RuiyuSun] * RuiyuSun https://github.com/RuiyuSun * Pending @AnningCheng-NOAA https://github.com/AnningCheng-NOAA Collaborator [image: @RuiyuSun] * RuiyuSun https://github.com/RuiyuSun * Pending @AnningCheng-NOAA https://github.com/AnningCheng-NOAA I am not familiar with this conversion. But I see the changes with the two coefficents. What is the reason for the changes? Thanks.

On Mon, Jul 24, 2023 at 8:44 AM Grant Firl @.> wrote: Merged #88 <#88> into ufs/dev. — Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFOCLEPXR6ODV6LGCXIASLXRZU2FANCNFSM6AAAAAAZZ6XUEY . You are receiving this because your review was requested.Message ID: @.>
-- Ruiyu Sun, PhD Lynker at NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2097 College Park, MD 20740 @.*** @.***> 301-683-3787

@RuiyuSun I don't see what this question is referring to? Could you recomment where in the code you're asking about? @AnningCheng-NOAA Can you respond to @RuiyuSun 's question?

@AnningCheng-NOAA
Copy link
Collaborator

AnningCheng-NOAA commented Jul 24, 2023 via email

@RuiyuSun
Copy link
Collaborator

I see. Thanks@AnningCheng-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants