-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Update weather model hash and correct behavior in Functional WorkflowTaskTests Jenkins stage #1068
Merged
MichaelLueken
merged 11 commits into
ufs-community:develop
from
MichaelLueken:feature/hash_update
Apr 15, 2024
Merged
[develop] Update weather model hash and correct behavior in Functional WorkflowTaskTests Jenkins stage #1068
MichaelLueken
merged 11 commits into
ufs-community:develop
from
MichaelLueken:feature/hash_update
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d parm/upp_parm to .gitignore file
… the Functional WorkflowTaskTests stage on Gaea
…g jobs won't keep the pipeline from progressing past the functional workflowtasktests stage
* modulefiles/build_hera_gnu.lua - Corrected the ufs-weather-model build on Hera GNU * Issue ufs-community#1066 - * ush/bash_utils/create_symlink_to_file.sh - Applied Mike Kavulich's changes to remove ln_vrfy and use positional arguments instead of named arguments * scripts/exregional_make_orog.sh - Changed to use positional arguents instead of named arguments while calling create_symlink_to_file function * scripts/exregiona_run_fcst.sh - Same * scripts/exregional_run_post.sh - Same
MichaelLueken
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin and
EdwardSnyder-NOAA
as code owners
April 9, 2024 14:55
It passed one we2e test on Derecho. Approving. |
chan-hoo
approved these changes
Apr 9, 2024
Thanks for the review and approval, @chan-hoo! |
I tested fundamental tests on Hera, GNU.
Looks good, approving. |
RatkoVasic-NOAA
approved these changes
Apr 9, 2024
Thanks, @RatkoVasic-NOAA! |
MichaelLueken
added
the
run_we2e_coverage_tests
Run the coverage set of SRW end-to-end tests
label
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
build_hera_gnu.lua
file to allow it to work with updates to the ufs-weather-model.Functional WorkflowTaskTests
Jenkins stage to allow the test to properly finish, rather than waiting in queue for all jobs associated with the EPIC role account to finish first (modification to.cicd/scripts/wrapper_srw_ftest.sh
).Functional WorkflowTaskTests
stage on Gaea.ush/bash_utils/create_symlink_to_file.sh
and converted calls to thecreate_symlink_to_file
function from using named arguments to positional arguments (Issuecreate_symlink_to_file.sh
is unreasonably slow #1066).Type of change
TESTS CONDUCTED:
Fundamental tests were ran on all machines and comprehensive tests were ran on Hera, Hercules, and Orion.
ISSUE:
Fixes #1066
CHECKLIST
CONTRIBUTORS (optional):
@mkavulich - For opening issue #1066 and providing the diff to convert
create_symlink_to_file
from using named arguments to positional arguments.