-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Bug fix to support the %H format in METplus via printf. #1102
[develop] Bug fix to support the %H format in METplus via printf. #1102
Conversation
@MichaelLueken I am running the vx WE2E tests on this now. |
@MichaelLueken All the WE2E vx tests passed, and I noted that in the PR message. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! I ran the non-HPSS verification WE2E tests on Hercules and all tests successfully passed:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
MET_ensemble_verification_only_vx_20240710074823 COMPLETE 1.97
MET_ensemble_verification_winter_wx_20240710074826 COMPLETE 153.22
MET_verification_only_vx_20240710074828 COMPLETE 0.59
MET_verification_20240710074830 COMPLETE 14.11
MET_ensemble_verification_2024071007483 COMPLETE 29.84
----------------------------------------------------------------------------------------------------
Total COMPLETE 199.73
and the HPSS verification WE2E tests successfully passed on Hera:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
MET_ensemble_verification_only_vx_time_lag_20240710153519 COMPLETE 3.57
MET_verification_winter_wx_20240710153521 COMPLETE 17.14
----------------------------------------------------------------------------------------------------
Total COMPLETE 20.71
Approving now.
The Jenkins WE2E coverage tests successfully passed on all machines, with the exception of Jet, where the testing phase was aborted for running longer than 8 hours. Before the tests were aborted, there were two failures - Both failures appear to be due to Slurm/Node issues on the machine. Tasks being allocated nodes and hanging until the walltime has passed:
Tasks not launching properly:
Manual running of the WE2E coverage tests were also launched on Jet yesterday. There are no time-outs for test stages while manually running, so the tests ran through to completion. Three tests ultimately failed with the above errors. Once resubmission of the failed tests successfully pass, this PR will be merged. |
@MichaelLueken Thanks for the update. |
The manual runs of the WE2E coverage tests successfully passed on Jet:
Moving forward with merging this work now. |
commit b368974 Author: Christina.Holt <[email protected]> Date: Sat Jul 13 02:42:24 2024 +0000 Linting. commit 5502cdc Author: Christina.Holt <[email protected]> Date: Fri Jul 12 22:58:49 2024 +0000 This should no longer be an executable bash file. commit 0a8cf97 Merge: 8b9eb07 e5832d1 Author: Christina.Holt <[email protected]> Date: Fri Jul 12 22:51:03 2024 +0000 Merge branch 'develop' of https://github.com/ufs-community/ufs-srweather-app into to_yaml commit 8b9eb07 Merge: 2ed368f f360da3 Author: Christina.Holt <[email protected]> Date: Fri Jul 12 22:47:59 2024 +0000 Merge branch 'to_yaml' of https://github.com/ChristinaholtNOAA/ufs-srweather-app into to_yaml commit 2ed368f Author: Christina.Holt <[email protected]> Date: Fri Jul 12 22:47:04 2024 +0000 Update docs for default values. commit b31f6c7 Author: Christina.Holt <[email protected]> Date: Fri Jul 12 22:41:29 2024 +0000 Applying suggested changes from review. commit e5832d1 Author: gsketefian <[email protected]> Date: Fri Jul 12 06:57:23 2024 -0600 [develop] Bug fix to support the %H format in METplus via printf. (ufs-community#1102) This bug was encountered when verifying forecast output that has a 2-digit forecast hour in its name. It turns out specifying the METplus format %H to obtain a 2-digit forecast hour in the workflow/verification configuration variable FCST_FN_TEMPLATE (and others) causes an error in the shell script eval_METplus_timestr_tmpl.sh because bash's printf utility does not support the %H format. This fixes that error using a similar approach to the %HHH format for obtaining 3-digit hours. commit f360da3 Author: Christina Holt <[email protected]> Date: Fri Jun 28 08:24:21 2024 -0600 Update jobs/JREGIONAL_MAKE_OROG Co-authored-by: Michael Lueken <[email protected]> commit 241ef5d Author: Christina.Holt <[email protected]> Date: Tue Jun 18 23:13:55 2024 +0000 A bit of clean up commit e242490 Author: Christina.Holt <[email protected]> Date: Tue Jun 18 16:50:48 2024 +0000 Add nco section to be sourced always. commit 253590f Author: Christina.Holt <[email protected]> Date: Mon Jun 17 19:41:55 2024 +0000 WIP commit d2a0bc2 Author: Christina.Holt <[email protected]> Date: Tue Jun 11 02:16:32 2024 +0000 Source from a function. commit 874af4b Author: Christina.Holt <[email protected]> Date: Tue Jun 11 02:16:10 2024 +0000 Bump uwtools version. commit 4ef89f6 Merge: 94d7970 81be59e Author: Christina.Holt <[email protected]> Date: Tue Jun 11 01:46:17 2024 +0000 Merge remote-tracking branch 'origin/develop' into to_yaml commit 94d7970 Author: Christina.Holt <[email protected]> Date: Tue Jun 11 01:40:37 2024 +0000 WIP commit f08e3ef Author: Christina.Holt <[email protected]> Date: Sat Apr 27 01:02:41 2024 +0000 Boolified. commit a6513cb Merge: 0d86ab0 c7e093d Author: Christina.Holt <[email protected]> Date: Tue Apr 23 12:45:01 2024 +0000 Merge remote-tracking branch 'origin/develop' into to_yaml commit 0d86ab0 Author: Christina.Holt <[email protected]> Date: Fri Apr 19 00:19:18 2024 +0000 Fix all the subshell problems. commit 4bec6b7 Author: Christina.Holt <[email protected]> Date: Fri Apr 19 00:12:14 2024 +0000 WIP commit a12f6fb Author: Christina.Holt <[email protected]> Date: Fri Apr 19 00:10:10 2024 +0000 WIP commit 444f1f0 Author: Christina.Holt <[email protected]> Date: Thu Apr 18 23:45:42 2024 +0000 WIP commit 16da1ef Author: Christina Holt <[email protected]> Date: Thu Apr 18 14:47:15 2024 -0600 Cleaning up old functionality. commit e5b28da Author: Christina Holt <[email protected]> Date: Thu Apr 18 14:35:59 2024 -0600 Ordering for sourced files. commit 8496c68 Author: Christina Holt <[email protected]> Date: Thu Apr 18 12:29:56 2024 -0600 Order jobs. commit 38f9daa Author: Christina.Holt <[email protected]> Date: Thu Apr 18 18:19:44 2024 +0000 Order docs. commit 446f6eb Author: Christina.Holt <[email protected]> Date: Thu Apr 18 14:13:22 2024 +0000 Finished up first round of ex-scripts commit 59d07d4 Author: Christina.Holt <[email protected]> Date: Thu Apr 18 02:39:49 2024 +0000 WIP commit 87e549f Author: Christina.Holt <[email protected]> Date: Thu Apr 11 23:03:43 2024 +0000 Keep same environment behavior for AQM jobs. commit 46c4805 Author: Christina.Holt <[email protected]> Date: Thu Apr 11 22:01:26 2024 +0000 Add machine to command commit 55b500b Author: Christina.Holt <[email protected]> Date: Thu Apr 11 21:56:41 2024 +0000 WIP Use UW-compliant YAML for var_defns.sh file. Update loading tasks script for not having all required variables in environment.
…s-community#1102) This bug was encountered when verifying forecast output that has a 2-digit forecast hour in its name. It turns out specifying the METplus format %H to obtain a 2-digit forecast hour in the workflow/verification configuration variable FCST_FN_TEMPLATE (and others) causes an error in the shell script eval_METplus_timestr_tmpl.sh because bash's printf utility does not support the %H format. This fixes that error using a similar approach to the %HHH format for obtaining 3-digit hours.
DESCRIPTION OF CHANGES:
This bug was encountered when verifying forecast output that has a 2-digit forecast hour in its name. It turns out specifying the METplus format
%H
to obtain a 2-digit forecast hour in the workflow/verification configuration variableFCST_FN_TEMPLATE
(and others) causes an error in the shell scripteval_METplus_timestr_tmpl.sh
because bash'sprintf
utility does not support the%H
format. This fixes that error using a similar approach to the%HHH
format for obtaining 3-digit hours.Type of change
TESTS CONDUCTED:
The full set of WE2E tests involving vx were run on Hera. These are:
All passed.
DEPENDENCIES:
None needed.
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@willmayfield and @michelleharrold encountered this bug, and @mkavulich pinpointed the script it was originating from.