-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Update requests and certifi in requirements.txt #1103
[develop]: Update requests and certifi in requirements.txt #1103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through and updating the versions of both certifi
and requests
, @gspetro-NOAA! Since you updated the "yanked" version of requests
as well, I think I would prefer to get this PR in, then close PR #1101.
Could the ./ufs-srweather-app/doc/README be updates as well in this PR? When sphinx, sphinx-rtd-theme have been installed (not going into the details of installations), the way to build the html documentaion requires the following: $ cd ufs-srweather-app/doc The above three lines would replace lines 23-24 in the current README |
@natalie-perlin I updated the doc README (and the regular README), but I used a two-line update rather than what you suggested. There should be no need to copy the |
Thank you for updating the README files as well, @gspetro-NOAA! Moving forward with merging this work now. |
…nity#1103) * The Dependabot PR ufs-community#1101 identified the need to update the certifi version, but requests should also be updated from the current (yanked) version in the requirements file. * The README.md and doc/README files have also been updated.
DESCRIPTION OF CHANGES:
The Dependabot PR #1101 identified the need to update the certifi version, but
requests
should also be updated from the current (yanked) version in the requirements file.Type of change
TESTS CONDUCTED:
None required. Generated the requirements file locally with the proposed upgrade to
certifi
and then resolved warnings generated by therequests
version. With these two updates, therequirements.txt
file can be generated without warnings or errors.DEPENDENCIES:
None.
DOCUMENTATION:
All documentation.
ISSUE:
Fixes issue identified in Dependabot PR #1101
CHECKLIST