[develop] Update ufs-weather-model hash and remove machine/modulefiles/WE2E test suites for decommissioned machines #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NRAL0032 account is overspent
…ommissioned machine, Cheyenne
MichaelLueken
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin and
EdwardSnyder-NOAA
as code owners
|
The |
|
Following the update of the paths to staged data on Jet (from /lfs4 to /lfs5), in |
…re previously failing in Derecho comprehensive WE2E test suite
|
In issue #947, four WE2E tests were commented out in the Derecho comprehensive WE2E test suite. They were commented out due to errors generated in the Uncommenting commented out WE2E tests from Derecho WE2E comprehensive suite now. |
RatkoVasic-NOAA
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Tested and approved:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2 COMPLETE 11.44
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 9.47
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 29.37
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024090 COMPLETE 49.78
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240906045 COMPLETE 33.55
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024090604551 COMPLETE 55.83
----------------------------------------------------------------------------------------------------
Total COMPLETE 189.44
EdwardSnyder-NOAA
approved these changes
Sep 19, 2024
MichaelLueken
added
the
run_we2e_coverage_tests
natalie-perlin
approved these changes
Sep 19, 2024
|
@MichaelLueken, did you test AQM with this PR? AQM is not compiled. I got the following error: |
chan-hoo
requested changes
Sep 20, 2024
|
The AQM WE2E test and sample configuration test were run on Hera prior to opening this PR. This morning, I was able to successfully build the AQM executables using the a1143cc hash of the weather model: After successfully building, the My build can be found Have you tried building AQM with the current develop? Between the July 30 hash (b5a1976) and the August 12 hash (a1143cc), there weren't any changes to FMS, which is what appears to be causing the failure in your attempt to build AQM with my feature branch. |
|
@MichaelLueken, thanks for your re-test. I am not sure what was wrong. I'll try it again on a new terminal window. |
chan-hoo
approved these changes
Sep 20, 2024
|
@MichaelLueken , it was compiled successfully on a new window. Approved. |
|
Thanks, @chan-hoo! |
|
The Jenkins tests successfully passed on Gaea, Hera Intel, Hera GNU, Hercules, and Orion. The Jenkins tests weren't run on Derecho, as the machine node was still down following maintenance. The coverage WE2E tests were manually run on Derecho and the tests successfully passed: On Jet, the Preparing to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
ContainerQuickstart.rstandRunSRW.rstto note the new container location on Jet (/lfs5 instead of /lfs4) and the location of the staged data (/lfs5 instead of /lfs4).make_sfc_climoin the comprehensive WE2E suite for Derecho (comprehensive.derecho). Once this PR is merged, issue Failures encountered in make_sfc_climo on Derecho #947 can be closed.Type of change
TESTS CONDUCTED:
CHECKLIST