[develop] Fixing bug: moved placing fix_lam tests' directories from common place (ufs-srweather-app) to each tests' run directory. #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causing it to overwrite content randomly.
RatkoVasic-NOAA
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin,
EdwardSnyder-NOAA and
MichaelLueken
as code owners
MichaelLueken
changed the title
…hera.intel.nco to allow the latter to successfully run without failure.
Switch custom grid WE2E tests for coverage.hera.gnu.com and coverage.hera.intel.nco
MichaelLueken
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
These changes look good to me! I was able to run the comprehensive tests on Hera and Orion. All tests successfully passed. Also, thank you for merging my modifications to the coverage.hera.gnu.com and coverage.hera.intel.nco suites. Once this PR is merged, all coverage and comprehensive WE2E tests should run and pass without issue.
21 tasks
gsketefian
approved these changes
Dec 7, 2023
MichaelLueken
added
the
run_we2e_coverage_tests
|
The WE2E coverage tests were manually run on Derecho and all successfully passed: The Jenkins tests failed to build on Jet due to exceeding disk quota on the machine. Both Hera Intel and Hera GNU lost communication with Jenkins while attempting to run the |
|
The Jenkins tests have successfully run on Gaea: Gaea-C5: Jet: Hercules: And Orion: Due to Hera allocation issues, the Hera Intel coverage tests were manually ran and all successfully passed: Moving forward with the merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
We noticed when running comprehensive tests that one particular test is failing (nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR), but when submitted separately, that test is working fine. Problem was that tests that use pre-staged files (orography, vegetation, snow,...) their fix files were staged in source directory (ufs-srweather-app/fix) instead of run directory. It works fine as long as tests have different resolution, but tests with same resolution, but different domain dimension (i.e. C403: RRFS_CONUS_25km & RRFS_CONUScompact_25km) have same name and second overwrites first:
Change was made to place fix directory in each tests' run directory.
Type of change
TESTS CONDUCTED:
ISSUE:
#974
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: