Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/public-v1: readlink error on macOS using build.sh #52

Closed
climbfuji opened this issue Feb 7, 2020 · 2 comments
Closed

release/public-v1: readlink error on macOS using build.sh #52

climbfuji opened this issue Feb 7, 2020 · 2 comments

Comments

@climbfuji
Copy link
Collaborator

When using build.sh on macOS, the script complains about readlink. This is because the default macOS readlink doesn't recognize the -f option used to determine MYDIR:

MYDIR=$(cd "$(dirname "$(readlink -f -n "${BASH_SOURCE[0]}" )" )" && pwd -P)

One can install the GNU readlink via homebrew, but this version is installed as greadlink. Two options: add logic to detect that the system is a macOS system and then call greadlink instead of readlink, or just try to do something less fancy (aka not working properly if build.sh is linked to somewhere else and then called from there - I don't think this is something we want anyway) and just use

MYDIR=`dirname "$BASH_SOURCE"`
MYDIR=$(realpath "${MYDIR}")

?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Feb 7, 2020 via email

@climbfuji
Copy link
Collaborator Author

Fixed in #74.

climbfuji added a commit to climbfuji/ufs-weather-model that referenced this issue Dec 18, 2020
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
* Use sfc_climo_gen code from the "develop" branch of UFS_UTILS instead of the previous feature branch.

* Add RUN_ENVIR parameter to switch between nco and community modes.

* Simplify set of possible values that VERBOSE takes on.

* Rename predefined domains for clarity and add new predefined domain (13km HRRR/CONUS).

* Set WORKDIR equal to EXPT_DIR so that the preprocessing subdirectories are under EXPT_DIR along with everything else.

* Remove creation of symlinks whose names don't contain the string "halo".  That is already done in stage_static.sh.

* Add copying of mosaic file from grid work directory to shave work directory so that all grid and orography files are in one place after the shave step.  This makes things more convenient for later tasks in the workflow (i.e. those after make_grid_orog).

* Add capability to read in grid and orography files from a specified directory instead of creating a grid.  Similarly, add capability to read in surface climatology files from a specified directory instead of generating these files.

* Fixes after testing workflow:

ush/checkout_repo.sh:
Change branch to use from feature/chgres_grib2_gsk to feature/chgres_grib2 since that has all the latest (and the _gsk one may have been overwritten).

ush/get_extrn_mdl_file_dir_info.sh:
Change variable name; remove debugging statements.

ush/get_extrn_mdl_files.sh:
Put in a check for the availability of external model data on the specified CDATE.

ush/make_ICS_surf_LBC0.sh:
Change cd to cd_vrfy; fix directory in which to look for surface climatology files.

ush/make_LBC1_to_LBCN.sh:
Change cd to cd_vrfy; fix directory in which to look for surface climatology files; fix bug involving input_type.

ush/run_FV3SAR.sh:
Change cd to cd_vrfy.

ush/stage_static.sh:
Put in fix so that RES and CRES are calculated only if the make_grid_orog task is not being run.  Also, put in fix to set these variables in the variable definitions file.

ush/templates/FV3SAR_wflow.xml:
Make file non-executable.

* Fix bug (directory being considered should be the one for LBCS, not ICSSURF).

* Changes to NCL code to allow finding of write-component grid parameters on 13km HRRR (CONUS) grid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants