Update weekly tests and remove run directories that are no longer needed by other tests #1004
Conversation
tests/run_test.sh
Outdated
| # Remove RUN_DIRs if they are no longer needed by other tests | ||
| ################################################################################ | ||
| keep_run_dir=false | ||
| if [[ ${TEST_NAME} == 'cpld_control_c96_p7' || ${TEST_NAME} == 'cpld_control_c192_p7' ]]; then |
There was a problem hiding this comment.
Since those tests may be changed to a different name, we will have to change this script often. I'd suggest to use a more general way to decide which tests should be kept.
There was a problem hiding this comment.
I do not like all these special cases. Very difficult to maintain. run_test.sh should not have any code that depends on the test name. Variable $TEST_NAME is only used for log files. We should be able to rename all test to something else and everything should work.
There was a problem hiding this comment.
@junwang-noaa If the run directory from a test needs to be kept, can we just add a suffix to the test name? For example, cpld_control_c96_p7 becomes cpld_control_c96_p7.dep.
In run_test.sh, we only need the following:
if [[ ${TEST_NAME} == *.dep ]]; then
keep_run_dir=true
fi
There was a problem hiding this comment.
@binli2337 I think this will add restriction on test name, and we don't know if there will be dependent test added later on. On the other hand, we already have the dependency information. The tests in the last column in rt.conf are the tests that other tests depends on and can only be deleted at the end of RT.
There was a problem hiding this comment.
@junwang-noaa The run_test.sh file is updated to use the information in the last column of rt.conf.
|
This PR will be combined with PR #1008. |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
The length of forecast for the "cpld_bmark_p7_35d" tests that are run weekly will be changed to 5 days.
During regression tests, many run directories are created and those run directories are removed only after all the tests are completed. To reduce disk space used during the tests, the "run_test.sh" script will be revised to remove run directories that are no longer needed by other tests during the regression tests.
Issue(s) addressed
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs