Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32-bit physics with FV3_RAP #1215

Merged
merged 95 commits into from
Jul 19, 2022
Merged
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
28731c5
Point to sing_prec_from_main branch of fv3atm and ccpp/physics
SamuelTrahanNOAA May 2, 2022
ff81f83
Update fv3atm .gitmodules
SamuelTrahanNOAA May 2, 2022
1a7a18a
Correct url for fv3
SamuelTrahanNOAA May 3, 2022
6bc0bc7
New CCPP_32BIT option for 32-bit slow physics. Requires 32BIT=ON to e…
SamuelTrahanNOAA May 4, 2022
85e6840
Point to Sam's branches of FV3 and stochastic_physics
SamuelTrahanNOAA May 4, 2022
8ed4a2d
32bit compiles with gnu. Some 64-bit tests have unchanged results.
SamuelTrahanNOAA May 4, 2022
9f80259
Merge community develop branch
SamuelTrahanNOAA May 4, 2022
55c9ce3
Revise ccpp-physics changes to pass 64-bit gnu regression tests (inte…
SamuelTrahanNOAA May 5, 2022
7d12839
Use double precision for stochastic_physics noise generator.
SamuelTrahanNOAA May 6, 2022
7abc683
switch ssh -> https
SamuelTrahanNOAA May 24, 2022
b1b402a
switch ssh -> https in FV3
SamuelTrahanNOAA May 24, 2022
3d47b85
hera gnu tests passed again
SamuelTrahanNOAA May 25, 2022
64a302f
32bit.conf has 32-bit regression tests; added complete set of hrrr_co…
SamuelTrahanNOAA May 27, 2022
7cf9921
call w3nco correctly (from dusan's branch)
SamuelTrahanNOAA May 27, 2022
9419a09
All suites can compile 32-bit.
SamuelTrahanNOAA May 27, 2022
dc8b533
merge f09e45bfd8420c8456f67db6ccb54b30b246b852 from develop
SamuelTrahanNOAA Jun 21, 2022
4518eff
merge 0ee3448609bac7da3fa2ec57292103eabbda6835 from develop
SamuelTrahanNOAA Jun 21, 2022
db2fe91
Merge commit '38f4f6a3ae98c2a4b4fd83067a349e62d93b784c' into working_…
SamuelTrahanNOAA Jun 21, 2022
298f4ac
merge b751b8d5e37d68324376161193d20bd28e8e116b
SamuelTrahanNOAA Jun 22, 2022
c3533ef
merge 5c2d1a92ecd7bceb3f0f83f832551a250dae4997 (gsl fork)
SamuelTrahanNOAA Jun 22, 2022
9c0a055
Merge commit 'bea6b56ffcffb73a3080dcf882f8020282b6b43b' into working_…
SamuelTrahanNOAA Jun 22, 2022
f1581b0
Merge commit '6f7906adad0ec6bcd3eefaf0e3c74dabccec6e0f' into working_…
SamuelTrahanNOAA Jun 22, 2022
c1da60f
Merge commit '2f0512198c3c2edacec1d77f7c2fc435081ca196' into working_…
SamuelTrahanNOAA Jun 22, 2022
ee2b14b
merge 6b6462b8d817a5e65222c62d3b2ba1b75b543ee6 (ccppv6 bugfixes)
SamuelTrahanNOAA Jun 22, 2022
d9cd37c
merge 71c752af5205c2ca11b13243b18c253c5481f13a (neptune 32-bit chang…
SamuelTrahanNOAA Jun 22, 2022
e0a4a81
FV3/ccpp/physics: Clean up machine.F and get rid of kind_evod & kind_rad
SamuelTrahanNOAA Jun 22, 2022
85ac1f7
Merge commit '66c729118bce282f947a95ee798f756c8182308f' into working_…
SamuelTrahanNOAA Jun 22, 2022
27713b3
merge a86d5a2ff35196148ea56b2623820336e9654481 (Add prognostic cumulu…
SamuelTrahanNOAA Jun 22, 2022
43adf2c
merge dc1316cc929862435228829fa7048a329de0afab ("correct fv3 hash")
SamuelTrahanNOAA Jun 22, 2022
95ce4e7
merge bfecf91b70fe484c5af43a0303977c7b5a3583fa ("Bring exchange grid…
SamuelTrahanNOAA Jun 22, 2022
5c52f77
merge ff8a6d36f94767519ded7f1becaea75b53f52080 ("Add 2d domain decom…
SamuelTrahanNOAA Jun 22, 2022
10b1f28
merge 455d8a96791e425aa92cb84071290b6e81062357 (lots of bug fixes)
SamuelTrahanNOAA Jun 23, 2022
421d6af
in ccpp/physics merge a35dfda1, and make similar updates to FV3 (hope…
SamuelTrahanNOAA Jun 23, 2022
9ed7857
bug fixes: 12hr forecasts, 45 min wallclock, io changes only for CCPP…
SamuelTrahanNOAA Jun 23, 2022
9db13d7
more tests in 32bit.conf
SamuelTrahanNOAA Jun 23, 2022
3e1166d
32/64 bit tests
SamuelTrahanNOAA Jun 23, 2022
e2593c7
more 32bit tests
SamuelTrahanNOAA Jun 23, 2022
fe0e07a
remove dead_compile bug from rt.sh
SamuelTrahanNOAA Jun 23, 2022
a87984f
merge remote working_32bit to local
SamuelTrahanNOAA Jun 23, 2022
45f7894
update FV3 hash
SamuelTrahanNOAA Jun 23, 2022
4b6d954
jet intel tests passed
SamuelTrahanNOAA Jun 23, 2022
62c7ef3
revert rap tests to community version
SamuelTrahanNOAA Jun 23, 2022
f614de0
merge working_32bit branch
SamuelTrahanNOAA Jun 23, 2022
b704928
32-bit tests
SamuelTrahanNOAA Jun 23, 2022
45c1ac6
corrections to 32bit restart
SamuelTrahanNOAA Jun 23, 2022
a48efc9
hera gnu tests passed
SamuelTrahanNOAA Jun 24, 2022
f1f4dc4
hera intel tests passed
SamuelTrahanNOAA Jun 24, 2022
33fd2bf
add 32-bit tests to rt.conf and rt_gnu.conf
SamuelTrahanNOAA Jun 24, 2022
4e23ca9
CMakeLists option descriptions were backwards
SamuelTrahanNOAA Jun 24, 2022
a1cba3e
Reduce 32-bit test forecast lengths and revert to 30 minute wallclock…
SamuelTrahanNOAA Jun 27, 2022
6fd9406
Merge develop
SamuelTrahanNOAA Jun 27, 2022
91566c9
point to authoritative repository for rte-rrtmgp
SamuelTrahanNOAA Jun 27, 2022
18559f7
revert to an earlier FV3/atmos_cubed_sphere because the community ver…
SamuelTrahanNOAA Jun 27, 2022
a94835c
hera gnu logs
SamuelTrahanNOAA Jun 27, 2022
23c12a1
hera intel tests passed
SamuelTrahanNOAA Jun 27, 2022
97af314
Jet tests passed.
SamuelTrahanNOAA Jun 28, 2022
8218857
Merge branch 'sing_prec_from_main' of ssh://github.com/SamuelTrahanNO…
SamuelTrahanNOAA Jun 28, 2022
13607dc
merge develop
SamuelTrahanNOAA Jul 1, 2022
839b1d0
correct a type mismatch in a call in module_sf_noahmplsm in CCPP
SamuelTrahanNOAA Jul 1, 2022
9e8c03c
hera gnu tests passed
SamuelTrahanNOAA Jul 1, 2022
e8c16eb
hera intel tests passed
SamuelTrahanNOAA Jul 1, 2022
12b6e00
jet intel tests passed
SamuelTrahanNOAA Jul 1, 2022
88e9f74
better names for new variables in FV3/ccpp/physics/physics/module_sf_…
SamuelTrahanNOAA Jul 5, 2022
aa8e24d
Merge branch 'sing_prec_from_main' of ssh://github.com/SamuelTrahanNO…
SamuelTrahanNOAA Jul 5, 2022
eaf9398
merge develop
SamuelTrahanNOAA Jul 5, 2022
477c659
hera.gnu passed again
SamuelTrahanNOAA Jul 5, 2022
73aefa6
hera.intel tests passed
SamuelTrahanNOAA Jul 5, 2022
00cd4e9
merge develop
SamuelTrahanNOAA Jul 7, 2022
fb7ca43
hera gnu tests passed
SamuelTrahanNOAA Jul 7, 2022
a623b59
jet intel tests passed
SamuelTrahanNOAA Jul 7, 2022
a73fea5
Merge branch 'sing_prec_from_main' of ssh://github.com/SamuelTrahanNO…
SamuelTrahanNOAA Jul 7, 2022
b2d3acf
merge develop
SamuelTrahanNOAA Jul 13, 2022
e45da27
LHEATSTRG=.false. in 32-bit tests & 24-hour forecats in rap
SamuelTrahanNOAA Jul 13, 2022
ea0ae82
12hr forecast length for rap_control_dyn64_phy32
SamuelTrahanNOAA Jul 14, 2022
810d570
hera intel tests passed
SamuelTrahanNOAA Jul 14, 2022
5660f99
hera gnu tests passed
SamuelTrahanNOAA Jul 14, 2022
aba9498
jet intel tests passed
SamuelTrahanNOAA Jul 14, 2022
f3d5e4f
merge develop
SamuelTrahanNOAA Jul 15, 2022
e157c56
merge remote branch
SamuelTrahanNOAA Jul 15, 2022
c0049e1
hera.gnu tests passed
SamuelTrahanNOAA Jul 15, 2022
d0f248c
wcoss2.intel RT passed
BrianCurtis-NOAA Jul 15, 2022
9f5f8df
add orion.intel RT log: passed
jkbk2004 Jul 15, 2022
1509056
add here.intel RT log: passed
jkbk2004 Jul 18, 2022
4438a7f
add gaea.intel RT log: passed
jkbk2004 Jul 18, 2022
8ed4b75
add jet.intel RT log: passed
jkbk2004 Jul 18, 2022
14462fa
add cheyenne intel/gnu RT logs: passed
jkbk2004 Jul 18, 2022
35a8195
add hera.gnu RT log: passed
jkbk2004 Jul 19, 2022
1d1cc81
point to NCAR main ccpp-physics
SamuelTrahanNOAA Jul 19, 2022
3cc9ee1
Merge branch 'sing_prec_from_main' of ssh://github.com/SamuelTrahanNO…
SamuelTrahanNOAA Jul 19, 2022
710137f
point to dev/emc atmos_cubed_sphere
SamuelTrahanNOAA Jul 19, 2022
a5830ce
point to noaa-psd master stochastic_physics
SamuelTrahanNOAA Jul 19, 2022
28bbede
point to fv3emc develop FV3
SamuelTrahanNOAA Jul 19, 2022
88a828e
Merge branch 'sing_prec_from_main' of ssh://github.com/SamuelTrahanNO…
SamuelTrahanNOAA Jul 19, 2022
ec92a8e
remove two files that were only present for testing
SamuelTrahanNOAA Jul 19, 2022
a38a614
update FV3 hash
SamuelTrahanNOAA Jul 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/SamuelTrahanNOAA/fv3atm
branch = sing_prec_from_main
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
branch = dev/ufs-weather-model
[submodule "stochastic_physics"]
path = stochastic_physics
url = https://github.com/noaa-psd/stochastic_physics
url = https://github.com/SamuelTrahanNOAA/stochastic_physics
branch = master
[submodule "CMakeModules"]
path = CMakeModules
Expand Down
4 changes: 3 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ message("CMEPS ............ ${CMEPS}")
###############################################################################
### Build Options
###############################################################################
set(32BIT OFF CACHE BOOL "Enable 32BIT (single precision arithmetic in dycore)")
set(32BIT OFF CACHE BOOL "Enable 32BIT (single precision arithmetic in dycore and fast physics)")
set(CCPP_32BIT OFF CACHE BOOL "Enable CCPP_32BIT (single precision arithmetic in slow physics)")
set(AVX2 ON CACHE BOOL "Enable AVX2 instruction set")
set(AVX OFF CACHE BOOL "Enable AVX-I instruction set")
set(SIMDMULTIARCH OFF CACHE BOOL "Enable multi-target SIMD instruction sets")
Expand All @@ -81,6 +82,7 @@ endif()

message("")
message("32BIT ............ ${32BIT}")
message("CCPP_32BIT ....... ${CCPP_32BIT}")
message("AVX2 ............. ${AVX2}")
message("SIMDMULTIARCH .... ${SIMDMULTIARCH}")
message("DEBUG ............ ${DEBUG}")
Expand Down
19 changes: 19 additions & 0 deletions tests/32bit.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON | | fv3 |
SamuelTrahanNOAA marked this conversation as resolved.
Show resolved Hide resolved
RUN | regional_spp_sppt_shum_skeb_dyn32_phy32 | | fv3 |
RUN | rap_control_dyn32_phy32 | | fv3 |
RUN | hrrr_control_dyn32_phy32 | | fv3 |
RUN | rap_2threads_dyn32_phy32 | | |
RUN | hrrr_control_2threads_dyn32_phy32 | | |
RUN | hrrr_control_decomp_dyn32_phy32 | | |
RUN | rap_restart_dyn32_phy32 | | | rap_control_dyn32_phy32
RUN | hrrr_control_restart_dyn32_phy32 | | | hrrr_control_dyn32_phy32

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -DCCPP_32BIT=ON | | fv3 |
RUN | rap_control_dyn64_phy32 | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON -DDEBUG=ON | | fv3 |
RUN | rap_control_debug_dyn32_phy32 | | fv3 |
RUN | hrrr_control_debug_dyn32_phy32 | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -DCCPP_32BIT=ON -DDEBUG=ON | | fv3 |
RUN | rap_control_dyn64_phy32_debug | | fv3 |
21 changes: 21 additions & 0 deletions tests/32bit_gnu.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON | | fv3 |
RUN | rap_control_dyn32_phy32 | | fv3 |
RUN | hrrr_control_dyn32_phy32 | | fv3 |
RUN | rap_2threads_dyn32_phy32 | | |
RUN | hrrr_control_2threads_dyn32_phy32 | | |
RUN | hrrr_control_decomp_dyn32_phy32 | | |
RUN | rap_restart_dyn32_phy32 | | | rap_control_dyn32_phy32
RUN | hrrr_control_restart_dyn32_phy32 | | | hrrr_control_dyn32_phy32

# This one is too slow with gnu compiler due to extremely low levels of optimization.
# RUN | regional_spp_sppt_shum_ske | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_32BIT=ON | | fv3 |
RUN | rap_control_dyn64_phy32 | | fv3 |

COMPILE | -DAPP=ATM -D32BIT=ON -DCCPP_32BIT=ON -DDEBUG=ON | | fv3 |
RUN | rap_control_debug_dyn32_phy32 | | fv3 |
RUN | hrrr_control_debug_dyn32_phy32 | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_32BIT=ON -DDEBUG=ON | | fv3 |
RUN | rap_control_dyn64_phy32_debug | | fv3 |
Loading