NCAR/main PR #66 (Bugfix and optimization of prognostic closure for the P8 physics suite) #1451
Conversation
|
New baselines are needed for the test: control_c384_progsigma This update does not change the results in the control tests. |
|
@grantfirl @ChunxiZhang-NOAA @BrianCurtis-NOAA @zach1221 I am adding new BL_DATE. baseline change only for control_c384_progsigma. I will manually create that case and copy over with all other existing cases. |
@dustinswales FYI: comment above |
|
@dustinswales please bring these up to date with respective authoritative repositories
|
…r-model into ncar-main-PR967
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
|
Automated RT Failure Notification |
zach1221
added
jenkins-ci
|
Jenkins-CI run logs attached. |
|
@BrianCurtis-NOAA what about the RT run on wcoss2? |
jkbk2004
requested review from
ChunxiZhang-NOAA,
jkbk2004 and
BrianCurtis-NOAA
Same question. I didn't see the RT log for wcoss2. |
|
@jkbk2004 Can you copy the RT test check boxes from the PR template for this PR and fill them out acordingly? |
|
@dustinswales we need to start merging process. @ChunxiZhang-NOAA ccpp dependency first? Can you merge in on ccpp side first? |
|
@jkbk2004 Merged into ufs/dev. |
|
@dustinswales Time to update fv3atm hash and revert branch in gitmodules. |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR corrects a bug when using the prognostic closure (progsigma = true) to compute the q-tendency due to microphysics even if the diagnostic flags are false. It also optimizes the cloudbase massflux value for shallow and deep convection to work with the overall P8 physics suite.
New baselines are needed for the test: control_c384_progsigma
This update does not change the results in the control tests.
###issues
It addresses the issue: NCAR/ccpp-physics#960
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
###dependencies
NCAR/ccpp-physics#967
ufs-community/ccpp-physics#13
@lisa-bengtsson