Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ATMW / ATMAERO / HAFS WM configurations #2160

Merged
merged 25 commits into from
Apr 15, 2024
Merged

Document ATMW / ATMAERO / HAFS WM configurations #2160

merged 25 commits into from
Apr 15, 2024

Conversation

rickgrubin-tomorrow
Copy link
Contributor

@rickgrubin-tomorrow rickgrubin-tomorrow commented Feb 27, 2024 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers. N/A
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules N/A
  • Commit 'test_changes.list' from previous step N/A

Description:

Document the ATMW / ATMAERO / HAFS WM configurations added to UFS Weather Model User’s Guide | Configurations.

Files changed:

* UFSWM 
  * doc/Userguide
    * source
      * conf.py
      * Configurations.rst
      * FAQ.rst
      * InputsOutputs.rst
      * Introduction.rst

Commit Message:

Document WM ATMW / ATMAERO / HAFS WM configurations

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@rickgrubin-tomorrow rickgrubin-tomorrow changed the title Us 27 Document ATMW / ATMAERO / HAFS WM configurations Feb 27, 2024
@rickgrubin-tomorrow rickgrubin-tomorrow marked this pull request as ready for review February 28, 2024 17:16
rickgrubin-tomorrow and others added 9 commits March 8, 2024 09:39
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
53d3109 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
afd1784 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
fd8e617 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
16f5585 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
f2ba694 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
2e8ce6c 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
c2de392 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow @gspetro-NOAA
Update doc/UsersGuide/source/Configurations.rst
4e18fff 
Co-authored-by: Gillian Petro <[email protected]>
@rickgrubin-tomorrow
Update RRFS section to match current community develop branch
0404b45
gspetro-NOAA
gspetro-NOAA approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickgrubin-tomorrow has incorporated my suggested changes. PR approved.

@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. documentation Improvements or additions to documentation labels Apr 15, 2024
@zach1221 zach1221 merged commit 4f32a4b into ufs-community:develop Apr 15, 2024
2 of 4 checks passed
zhanglikate added a commit to zhanglikate/ufs-weather-model that referenced this pull request May 3, 2024
@zhanglikate
Squashed commit of the following:
2ce5436 
commit f234a3e
Author: Ufuk Turunçoğlu <[email protected]>
Date:   Tue Apr 30 11:35:25 2024 -0600

    Fix for land component model (ufs-community#2191)

    * UFSWM - fix fully coupled land component configuration
      * NOAHMP - get fixed information from surface file

commit 04bbc15
Author: jiandewang <[email protected]>
Date:   Thu Apr 25 14:52:00 2024 -0400

    update MOM6 to its main repo. 20240401 commit (ufs-community#2241)

    * UFSWM -
      * MOM6 - update MOM6 to its main repo. 20240401 commit (NCAR-candidate-20240319)

commit b6c576d
Author: Daniel Sarmiento <[email protected]>
Date:   Tue Apr 23 12:24:22 2024 -0400

    Merged global namelist (ufs-community#2173)

    * UFSWM - global_control.nml_IN has been added as the new regression test namelist template for all global regression tests. The namelist now uses pointers (i.e. @[abc]) for variables and default values have been added to the default_vars.sh script. A new section in default_vars.sh has been added (export_tiled) to account for tiled RTs that pulls the correct parameter files using the ATMRES variable.
    Regression tests have been modified to account for these changes. Tests that were not compatible with the GFSv17_p8 core have been disabled for now. They will be turned on as they are updated from GFSv16 to GFSv17.

commit 5d2ca19
Author: WenMeng-NOAA <[email protected]>
Date:   Fri Apr 19 13:59:12 2024 -0400

    Update upp submodule (ufs-community#2213)

    * UFSWM - Update inline post
      * FV3 - Update upp submodule for inline post

commit 47c0099
Author: Brian Curtis <[email protected]>
Date:   Wed Apr 17 15:59:48 2024 -0400

    Add bash linting to CI. Cleanup .sh scripts a bit. Address .sh bugs. Adds -v Verbose option. (ufs-community#2218)  Remove nowarn Intel compiler flag (ufs-community#2225)

    * UFSWM
    - Add bash linting to CI:
      - uses superlinter to check for consistent bash code writing
    - Cleans up .sh scripts to comply with superlinter
    - Cleans up .sh scripts to be more consistent, easier to read.
    - Add's -v verbose option if debugging outputs needed, otherwise simplifies rt.sh run echo's.
    - Addresses smaller bugs
      - quota/timeout search logic adjusted.
      - check for dirs existing (DISKNM, STMP, PTMP) before starting.
      - adjustments/cleanup to ecflow/rocoto sections
      - rt.sh will attempt to start ecflow, and only stop ecflow if it started from rt.sh.
      - fix for issue where run_dir will not delete properly.
    * FV3: Address compiler warnings
      * atmos_cubed_sphere: Address compiler warnings.

commit 4f32a4b
Author: Rick Grubin <[email protected]>
Date:   Mon Apr 15 07:21:08 2024 -0600

    Document ATMW / ATMAERO / HAFS WM configurations (ufs-community#2160)

    * UFSWM
      * doc/Userguide
        * source
          * conf.py
          * Configurations.rst
          * FAQ.rst
          * InputsOutputs.rst
          * Introduction.rst

commit ac4445d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 08:59:42 2024 -0400

    Bump idna from 3.6 to 3.7 in /doc/UsersGuide (ufs-community#2234)

    *doc/UserGuide
       *requirements.txt - updates inda version from 3.6 to 3.7

commit 281b32f
Author: Samuel Trahan (NOAA contractor) <[email protected]>
Date:   Mon Apr 15 08:38:01 2024 -0400

    bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (ufs-community#2201)

    * UFSWM - None.
      * FV3 - Write component will use kchunk3d. Model init sends the right tile number to CCPP.
        * atmos_cubed_sphere - Initialize the hailwat variable. Pass global_tile index to model.

commit 8a5f711
Author: Denise Worthen <[email protected]>
Date:   Thu Apr 11 13:32:26 2024 -0400

    Add PIO namelist control for CICE (ufs-community#2145)

    Update to CICE-Consortium/CICE aca8357. Adds implementation of namelist PIO options for CICE

commit 45c8b2a
Author: JONG KIM <[email protected]>
Date:   Thu Apr 4 19:49:13 2024 -0400

    Hotfix/cubed sphere hash fix: HAILCAST diagnostic code (units issue) (ufs-community#2223)

    cubed_sphere hash update: f060e85 for a bug- fix in the HAILCAST diagnostic code (units issue)

commit 26e6db6
Author: Denise Worthen <[email protected]>
Date:   Wed Apr 3 19:57:08 2024 -0400

    Enable cpl_scalars export from ATM and NoahMP for use by CMEPS (ufs-community#2175)

      * CMEPS - allow additional dimension in cpl_scalars for CSG and regional ATM domains for use in mediator history files
      * CMEPS - fix mapping mask for lnd->atm
      * FV3 - add export of cpl_scalars
      * NOAHMP - add export of cpl_scalars

commit 1411b90
Author: Dusan Jovic <[email protected]>
Date:   Mon Apr 1 18:04:44 2024 -0400

    Update module_write_netcdf to avoid hangs in RRFS runs (ufs-community#2193)

    * UFSWM - Update module_write_netcdf to avoid hangs in RRFS runs
      * FV3 - Update module_write_netcdf to avoid hangs in RRFS runs

commit 87c27b9
Author: Matthew Masarik <[email protected]>
Date:   Fri Mar 29 15:23:42 2024 -0400

    WW3 feature:  Langmuir turbulence parameterization (ufs-community#2195)

      * WW3 - Langmuir turbulence parameterization

commit c54e986
Author: Samuel Trahan (NOAA contractor) <[email protected]>
Date:   Wed Mar 27 16:11:03 2024 -0400

    regression test system bug fixes, eliminate MOM6 warnings (ufs-community#2197), add xr_cnvcld flag to FV3 (ufs-community#2185) (ufs-community#2202)

    * UFSWM - atparse.bash: correctly handle input that doesn't end with an end-of-line character. Fix some bugs in Rocoto support and clean up rt.sh.
      * FV3 - namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite
        * ccpp - physics-level changes to implement new namelist variable
      * MOM6 - update MOM6 code to eliminate all compiler warnings
@grantfirl grantfirl mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspetro-NOAA gspetro-NOAA gspetro-NOAA approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@zach1221 zach1221 Awaiting requested review from zach1221

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickgrubin-tomorrow @jkbk2004 @BrianCurtis-NOAA @gspetro-NOAA @zach1221