Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update mom6 20210402 #514

Closed

Conversation

jiandewang
Copy link
Collaborator

@jiandewang jiandewang commented Apr 9, 2021

PR Checklist

  • [x ] Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • [x ] This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • [x ] An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

GFDL updated main branch on 20210402 (see detail at https://github.com/NOAA-GFDL/MOM6/pull/1358#issuecomment-811919139). This updating will make EMC and GFDL main repository on the same page.

Issue(s) addressed

Testing

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

@climbfuji
Copy link
Collaborator

Does this PR change baselines? If not, can we combine it with another PR?

@jiandewang
Copy link
Collaborator Author

Does this PR change baselines? If not, can we combine it with another PR?

no answer change, no any new input file required

@climbfuji climbfuji added the No Baseline Change No Baseline Change label Apr 9, 2021
@DeniseWorthen
Copy link
Collaborator

@jiandewang I do want to change some files at the app level to set a default value for the new allow_landmask_changes parameter setting. this will allow me to test the feature using the develop branch. I will make a PR to your branch today.

@jiandewang
Copy link
Collaborator Author

@DeniseWorthen your change will be in MOM_input_template, right?

@DeniseWorthen
Copy link
Collaborator

@jiandewang Yes, only in default_vars, and the input templates.

DeniseWorthen and others added 3 commits April 9, 2021 11:01
* tested cpld_controlfrac,cpld_controlfrac_c192,cpld_controlfrac_c384
datm_control_cfs,datm_control_gefs,datm_mx025_cfsr,datm_mx025_gefs
* all tests passed
@climbfuji
Copy link
Collaborator

This PR is combined with/pulled into #488 and will be merged as part of it.

@climbfuji
Copy link
Collaborator

#488 has been merged, this PR can be closed.

@climbfuji climbfuji closed this Apr 12, 2021
@jiandewang jiandewang deleted the feature/update-MOM6-20210402 branch February 28, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants