Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT]: DRL_battery.py script - parameters improvement #298

Closed
2 tasks done
AlejandroCN7 opened this issue Mar 1, 2023 · 0 comments · Fixed by #299
Closed
2 tasks done

[IMPROVEMENT]: DRL_battery.py script - parameters improvement #298

AlejandroCN7 opened this issue Mar 1, 2023 · 0 comments · Fixed by #299
Assignees
Labels
DRL Deep Reinforcement Learning issues enhancement New feature or request

Comments

@AlejandroCN7
Copy link
Member

Improvement 🔧

In order to make experiments with sinergym more easily and in view of being able to expand the set of algorithms and hyperparameters used, it is proposed to change the definition of these parameters to a YAML or JSON structure. Thanks to @Melon-PieldeSapo for the idea :).

Original behavior

Current call to experiment:

python scripts/DRL_battery.py --environment ... --algorithm ... --evaluation ...

Enhanced behavior

For example:

python scripts/DRL_battery.py -conf experiment_config.json

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)

📝 Please, don't forget to include more labels besides enhancement if it is necessary.

@AlejandroCN7 AlejandroCN7 added enhancement New feature or request DRL Deep Reinforcement Learning issues labels Mar 1, 2023
@AlejandroCN7 AlejandroCN7 self-assigned this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DRL Deep Reinforcement Learning issues enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant