Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2.2.6) DRL_battery.py configuration improvement with JSON configuration mode #299

Merged
merged 16 commits into from
Mar 14, 2023

Conversation

AlejandroCN7
Copy link
Member

@AlejandroCN7 AlejandroCN7 commented Mar 2, 2023

Description

DRL_battery.py configuration improvement with JSON configuration mode

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #298
Fixes #283

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Added example of JSON configuration in scripts/.
  • Adapted scripts/DRL_battery.py to this new paradigm.
  • Fixed stable baselines 3 tests to gymnasium format.
  • Fixed info structure in callbacks.py and evaluation.py.
  • Updated documentation for new JSON structure.

@AlejandroCN7 AlejandroCN7 changed the title (v2.2.5) DRL_battery.py configuration improvement with JSON configuration mode (v2.2.6) DRL_battery.py configuration improvement with JSON configuration mode Mar 9, 2023
@AlejandroCN7 AlejandroCN7 marked this pull request as ready for review March 14, 2023 15:15
@AlejandroCN7 AlejandroCN7 merged commit 01a2abd into main Mar 14, 2023
@AlejandroCN7 AlejandroCN7 deleted the feat/issue298 branch March 14, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT]: DRL_battery.py script - parameters improvement [BUG]: isort issue when trying to run
1 participant