Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Migrate normalization of the action_space to a wrapper. #367

Closed
2 tasks done
AlejandroCN7 opened this issue Oct 19, 2023 · 0 comments · Fixed by #372
Closed
2 tasks done

[Enhancement]: Migrate normalization of the action_space to a wrapper. #367

AlejandroCN7 opened this issue Oct 19, 2023 · 0 comments · Fixed by #372
Assignees
Labels
enhancement New feature or request Env Improvements or additions to envs or gym wrapper Everything related to wrappers

Comments

@AlejandroCN7
Copy link
Member

Improvement 🔧

By default, normalization in action space is activated in our environments due to the fact that is required for some algorithms directly. However, I think it is a more general solution to do this work in a wrapper and make native Sinergym environments as simple as possible.

Original behavior

There is an attribute flag in Sinergym environments (default to True), to normalize observation and parse it to original values before to send the values to the simulator

Enhanced behavior

Encapsulate all this functionality into a wrapper, and write documentation to warn that this wrapper is required/recommended for some DRL algorithms.

Additional context

Add any other context about the problem here.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)

📝 Please, don't forget to include more labels besides enhancement if it is necessary.

@AlejandroCN7 AlejandroCN7 added enhancement New feature or request Env Improvements or additions to envs or gym wrapper Everything related to wrappers labels Oct 19, 2023
@AlejandroCN7 AlejandroCN7 self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Env Improvements or additions to envs or gym wrapper Everything related to wrappers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant