Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.0.8) NormalizeAction Wrapper migration from Sinergym Environment Module #372

Merged
merged 12 commits into from
Nov 10, 2023

Conversation

AlejandroCN7
Copy link
Member

@AlejandroCN7 AlejandroCN7 commented Nov 9, 2023

Description

In this PR, normalization of action space functionality is migrated from an environment flag to an individual wrapper.

normalize_action_wrapper

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fixes #367

For more information about motivation, read the closed issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Added a new wrapper called NormalizeAction.
  • Updated environment module: Deleted normalization_flag attribute and all its functionality.
  • Fixed tests and added tests for new wrapper.
  • Updated documentation and added a section for this wrapper.
  • Updated scripts examples for DRL training and loading models.
  • Updated notebooks.
  • Updated try_env.py example.

Extra

  • Updated docstrings in DiscretizeEnv wrapper.

@AlejandroCN7 AlejandroCN7 marked this pull request as ready for review November 10, 2023 09:09
@AlejandroCN7 AlejandroCN7 added enhancement New feature or request Env Improvements or additions to envs or gym wrapper Everything related to wrappers labels Nov 10, 2023
@AlejandroCN7 AlejandroCN7 merged commit 5a4a1c8 into main Nov 10, 2023
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/issue-367 branch January 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Env Improvements or additions to envs or gym wrapper Everything related to wrappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Migrate normalization of the action_space to a wrapper.
1 participant