Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.0.5) - Sinergym wrappers improvement #362

Merged
merged 4 commits into from
Sep 12, 2023
Merged

(v3.0.5) - Sinergym wrappers improvement #362

merged 4 commits into from
Sep 12, 2023

Conversation

AlejandroCN7
Copy link
Member

Description

This patch improves the Sinergym wrappers, being flexible in order, simpler and respecting the new gymnasium protocol on access to attributes from wrapper classes, which will be implemented in its future version 1.0.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #361

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Updated wrappers with new gymnasium standard to call attributes.
  • Updated tests and documentation.

@AlejandroCN7 AlejandroCN7 merged commit 627c95a into main Sep 12, 2023
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/issue-361 branch January 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update attribute reading to the new standard in future Gymnasium v1.0
1 participant