Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.1.2) - Sinergym Dockerfile fix #377

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Ahmed2BP
Copy link
Collaborator

Description

As mentioned in #376, there was a problem when installing Sinergym using Docker container and VS Code. This PR solves this issue.

Files were not being copied on the correct path. This resulted on source code changes not taking effect on experiments run inside the container.

Paths have been corrected and Sinergym version is updated.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #376

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Fixed Dockerfile bug.
  • Updated Sinergym version from 3.1.1 to 3.1.2.

@AlejandroCN7 AlejandroCN7 self-requested a review December 18, 2023 09:53
@AlejandroCN7 AlejandroCN7 merged commit 617492e into ugr-sail:main Dec 18, 2023
5 checks passed
@Ahmed2BP Ahmed2BP added the container All about containers label Jan 22, 2024
@Ahmed2BP Ahmed2BP deleted the bug/issue-376 branch April 3, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container All about containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Code changes not taking effect in Docker container
2 participants