Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty-lines regexp to match Windows line endings as well #991

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Apr 19, 2024

Windows line endings are represented by \r\n, which are counted as two two lines in the moment.

@uhafner uhafner added the bug Bugs or performance problems label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (979faa3) to head (72ea8fe).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #991   +/-   ##
=========================================
  Coverage     88.98%   88.98%           
  Complexity      181      181           
=========================================
  Files            11       11           
  Lines           717      717           
  Branches         93       93           
=========================================
  Hits            638      638           
  Misses           62       62           
  Partials         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

☀️   Quality Monitor

   🚦   Tests: 98 % successful (✔️ 96 passed, 🙈 2 skipped)
   〰️   Line Coverage: 91% (62 missed lines)
   ➰   Branch Coverage: 92% (19 missed branches)
   PIT   Mutation Coverage: 80% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings found
   PMD   PMD: 1 warning found (0 error, 0 high, 1 normal, 0 low)
   SpotBugs   SpotBugs: No warnings found

Created by Quality Monitor v1.7.0 (#823c682). More details are shown in the GitHub Checks Result.

Copy link

☀️   Quality Monitor

   🚦   Tests: 98 % successful (✔️ 95 passed, 🙈 2 skipped)
   〰️   Line Coverage: 91% (62 missed lines)
   ➰   Branch Coverage: 92% (19 missed branches)
   PIT   Mutation Coverage: 80% (75 survived mutations)
   CheckStyle   CheckStyle: No warnings found
   PMD   PMD: No warnings found
   SpotBugs   SpotBugs: No warnings found

Created by Quality Monitor v1.7.0 (#823c682). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit ef418c7 into main Apr 20, 2024
16 checks passed
@uhafner uhafner deleted the windows-line-endings branch April 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant