Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add all my packages #51

Merged
merged 4 commits into from
Jul 20, 2022
Merged

feat: Add all my packages #51

merged 4 commits into from
Jul 20, 2022

Conversation

mauriciolauffer
Copy link
Contributor

@mauriciolauffer mauriciolauffer commented Jul 10, 2022 •
edited
Loading

Add new NPM Package

Please make sure you meet these requirements first:

Prerequisites

  • Add link to your GitHub Repo in package.json (example)
  • Add a license to your project.
  • Add Author to your package.json (example).
  • NPM module published with current version.
  • ui5.yaml file present (example)

petermuessig
petermuessig reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uxkjaer - please check my inline comment

sources.json Outdated Show resolved Hide resolved
petermuessig
petermuessig reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More feedback

sources.json Outdated Show resolved Hide resolved
sources.json Outdated Show resolved Hide resolved
sources.json Outdated Show resolved Hide resolved
sources.json Outdated Show resolved Hide resolved
sources.json Outdated Show resolved Hide resolved
sources.json Outdated Show resolved Hide resolved
@marianfoo
Copy link
Member

@mauriciolauffer add library as enum

@marianfoo marianfoo linked an issue Jul 19, 2022 that may be closed by this pull request
change type of openui5-model-odata-v2-odatapromise to library #45
Closed
@marianfoo marianfoo mentioned this pull request Jul 19, 2022
Closed
marianfoo
marianfoo approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@marianfoo marianfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removed the full url
in repo is just the repo name necessary

@marianfoo marianfoo merged commit 1ebabb1 into main Jul 20, 2022
@marianfoo marianfoo deleted the lauffer-pkgs branch July 21, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uxkjaer uxkjaer uxkjaer left review comments

@petermuessig petermuessig petermuessig left review comments

@marianfoo marianfoo marianfoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change type of openui5-model-odata-v2-odatapromise to library
4 participants
@mauriciolauffer @marianfoo @petermuessig @uxkjaer