Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examine use of browserInstance in files client-side-js/ _navTo, injectTools, injectUI5, testLibrary? #281

Closed
vobu opened this issue Jun 20, 2022 · 1 comment
Closed

examine use of browserInstance in files client-side-js/ _navTo, injectTools, injectUI5, testLibrary? #281

vobu opened this issue Jun 20, 2022 · 1 comment

Comments

@vobu
Copy link
Contributor

vobu commented Jun 20, 2022

Why no use of browserInstance in files client-side-js/ _navTo, injectTools, injectUI5, testLibrary?

Originally posted by @dominikfeininger in #272 (comment)
monavari-lebrecht added a commit to monavari-lebrecht/wdi5 that referenced this issue Jun 20, 2022
@monavari-lebrecht
feat: ui5-community#281 add missing browser instance references to cl…
5b61960 
…iend side js
vobu pushed a commit that referenced this issue Jun 24, 2022
@monavari-lebrecht
feat: add multiremote support (#272)
fcb47cf 
* feat: add command asControl for multi remote to each browser

* feat: add support for multiremotedriver to call instances implicit

* feat: add support for ui5ready, navTo, make all tests running again

* feat: add missing browserinstance ref in browser js

* feat: move multiremote config to new location

* feat: add headless support for multiremote

* fix: remove DRY, due to prior merge conflict

* feat: #281 add missing browser instance references to cliend side js

* feat: set browser as default parameter for ui5 inject

* feat: change check for ui5 version on multiremote

* fix: linting issues

* chore: bump chromedriver to 103.0.0

* chore: set default screen size for testing cap to 1920x1280
@vobu
Copy link
Contributor Author

vobu commented Jun 28, 2022

closed via #272

@vobu vobu closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vobu