Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Version Checks #200

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Fix: Version Checks #200

merged 3 commits into from
Mar 24, 2022

Conversation

Siolto
Copy link
Collaborator

@Siolto Siolto commented Mar 24, 2022 •
edited
Loading

Remove unnecessary version checks (below version 1.60) and replace the parseFloat checks with semver

@vobu vobu merged commit 3648a98 into main Mar 24, 2022
@Siolto Siolto deleted the fix/wrong_version_checks branch March 24, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vobu vobu vobu approved these changes

@dominikfeininger dominikfeininger Awaiting requested review from dominikfeininger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siolto @vobu