Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(library): wdi5 assertions without browser service #430

Merged
merged 16 commits into from
Feb 24, 2023
Merged

fix(library): wdi5 assertions without browser service #430

merged 16 commits into from
Feb 24, 2023

Conversation

QA-ler
Copy link
Contributor

@QA-ler QA-ler commented Feb 23, 2023

No description provided.

@QA-ler
Copy link
Contributor Author

QA-ler commented Feb 23, 2023

If chromedriver service is not used the domElement is not set accordingly via devtool protocol.
Therefore we get the element reference by calling browser execute function manually

@QA-ler QA-ler mentioned this pull request Feb 23, 2023
Closed
vobu
vobu reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, nice finding!
I'll merge PR #404 so that these 2 can get in together

src/lib/wdi5-control.ts Outdated Show resolved Hide resolved
src/lib/wdi5-control.ts Outdated Show resolved Hide resolved
src/lib/wdi5-control.ts Outdated Show resolved Hide resolved
src/lib/wdi5-control.ts Show resolved Hide resolved
@vobu vobu mentioned this pull request Feb 23, 2023
Closed
@vobu
Copy link
Contributor

vobu commented Feb 23, 2023

we're almost there.
why the auth tests fail in CI, but run fine locally, must be investigated - but this is not in scope of this PR.
so @QA-ler , if you'd please change the wording the comment as suggested above, we should be good to provide a first version of wdi5 with devtools support!

QA-ler and others added 2 commits February 24, 2023 09:16
@QA-ler
Copy link
Contributor Author

QA-ler commented Feb 24, 2023

@vobu Done

@vobu vobu merged commit 5eb8254 into ui5-community:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vobu vobu vobu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QA-ler @vobu @adrianna-u