Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: outsource auth tests, drop node 14, make node 16 dev default, align script timeout #465

Merged
merged 48 commits into from
May 9, 2023

Conversation

vobu
Copy link
Contributor

@vobu vobu commented May 8, 2023

  • outsource auth tests w/ node 16 → browserstack
  • drop node 14 support
  • make node 16 the default dev env
  • align script timeout in browser-scope with wdi5's waitForUI5Timeout config setting (default: 15 sec.)

also lays the ground work for running other test against browserstack + saucelabs

@vobu
Copy link
Contributor Author

vobu commented May 8, 2023

Hey @Siolto - help with the FE sample app please... :)

@vobu vobu changed the title ci: outsource auth tests to browserstack ci: outsource auth tests, drop node 14, make node 16 dev default May 8, 2023
Copy link
Collaborator

@Siolto Siolto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node14 deprecation in docs and browser script timeout in pr description, rest looks good 👍

@vobu vobu changed the title ci: outsource auth tests, drop node 14, make node 16 dev default ci: outsource auth tests, drop node 14, make node 16 dev default, align script timeout May 9, 2023
@vobu vobu merged commit b2cb381 into main May 9, 2023
@vobu vobu deleted the ci/cloud-testing branch May 9, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants