-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: outsource auth tests, drop node 14, make node 16 dev default, align script timeout #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as we're working against a deployed app
This reverts commit 147c812.
as ts compiler (now!) complained
Hey @Siolto - help with the FE sample app please... :) |
vobu
changed the title
ci: outsource auth tests to browserstack
ci: outsource auth tests, drop node 14, make node 16 dev default
May 8, 2023
...as node16+ already come with an npm version capable of npm workspaces
Co-authored-by: Simon Coen <[email protected]>
for getting prebuilt libs
Siolto
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node14 deprecation in docs and browser script timeout in pr description, rest looks good 👍
vobu
changed the title
ci: outsource auth tests, drop node 14, make node 16 dev default
ci: outsource auth tests, drop node 14, make node 16 dev default, align script timeout
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wdi5
'swaitForUI5Timeout
config setting (default: 15 sec.)also lays the ground work for running other test against browserstack + saucelabs