Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance tests for exec using sinon #466

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philippthiele
Copy link
Contributor

No description provided.

@philippthiele
Copy link
Contributor Author

@vobu I do not seem to have any luck with the auth test 🤣

@vobu
Copy link
Contributor

vobu commented May 9, 2023

@vobu I do not seem to have any luck with the auth test 🤣

try merging in latest main (and hopefully marvel at the result) 🤣

@philippthiele
Copy link
Contributor Author

philippthiele commented May 9, 2023

@vobu please help 🙏

@vobu
Copy link
Contributor

vobu commented May 9, 2023

@vobu please help 🙏

TIL: "Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork."
gnarf.
let me come up with something to mitigate that.

@vobu
Copy link
Contributor

vobu commented Aug 24, 2023

hey @philippthiele - please "park" aka "move to Draft" this PR and wait for wdi5 2.0.
Then re-issue the PR against the then new main.
This is to save ourselves same back-and-forth merge effort :) Plus there'll hopefully be a solution for the dreaded secret handling in PRs from forked repos that you ran into...sorry again for that. gnarf.
Ok?

@philippthiele philippthiele marked this pull request as draft August 25, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants