implement prompt:none flow #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement prompt:none flow to match that proposed in uisautomation/hydra-consent-app#5. This commit is intended to keep the mock consent app and real consent app in lock step with regards to features. Update the app to cache the current subject in the flask session and automatically grant requests if there is a user in the session. This approximates the existing Raven behaviour. Teach the app about the "prompt:none" scope which signals that the request should be immediately rejected if there is not a user in the session.
Add /logout endpoint which can be used to explicitly log the current user out of the current session.
msb
suggested changes
Apr 18, 2018
The manner in which the constent requests are accepted/rejected is not
terribly obvious. Add explanatory comments to consent_{get,post} giving
an overview of how the process works.
Done in 25297d5 |
msb
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement prompt:none flow to match that proposed in uisautomation/hydra-consent-app#5. This commit is intended to keep the mock consent app and real consent app in lock step with regards to features.
Update the app to cache the current subject in the flask session and automatically grant requests if there is a user in the session. This approximates the existing Raven behaviour.
Teach the app about the "prompt:none" scope which signals that the request should be immediately rejected if there is not a user in the session.
This PR is required by uisautomation/iar-frontend#153.
Closes #1