This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
DO NOT MERGE: refresh Dockerfile a little #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in '25, our production Dockerfile is not as flexible as it could be. Enable configuration or OAUTH2_... settings via environment variables and add our logging configuration. Update the Dockerfile to be based on our common images.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 94.95% 94.07% -0.88%
==========================================
Files 25 25
Lines 753 760 +7
==========================================
Hits 715 715
- Misses 38 45 +7
Continue to review full report at Codecov.
|
|
What is the purpose of the changes? |
|
Primarily to allow us to use the production Docker image in our various webapps during development. This is the next biggest time cost for running CI jobs. That and we should start to make use of our shared images. This PR is sort of a "holding area" for the code change but, as outlined in the comment, I'm worried about merging before we have a test lookupproxy deployment. |
abrahammartin
approved these changes
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #25, our production Dockerfile is not as flexible as it could be. Enable configuration or OAUTH2_... settings via environment variables and add our logging configuration.
Update the Dockerfile to be based on our common images.
I've tagged this as DO NOT MERGE because we do not currently have a test infrastructure for lookupproxy so I'm loathe to merge such a fundamental modification to the Dockerfile without some test deployment to check first.