Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the ability to delete subtitles downloaded by agents #112

Closed
OttoKerner opened this issue Jan 14, 2016 · 5 comments
Closed

Restore the ability to delete subtitles downloaded by agents #112

OttoKerner opened this issue Jan 14, 2016 · 5 comments
Assignees
@dagalufh
Labels
enhancement
Milestone
V2.2

Comments

@OttoKerner
Copy link

see title

reason:
the opensubtitles plugin caused at some point in the past duplicated subtitles. Practically at every library refresh the same subtitles were downloaded again and again.
I don't know whether it is still doing this now, but your tool was about the only way to remove the duplicates.
So please consider re-enabling this ability.
@ukdtom ukdtom self-assigned this Jan 14, 2016
@ukdtom
Copy link
Owner

ukdtom commented Jan 14, 2016

Was intended as WAD, but logged as an enhancement for now...
But might have to wait, until UAS module has settled ;-)

@eduo
Copy link

eduo commented Jan 21, 2016

Is it possible to restore an older version that still supports it? By the time most people realize what the agent is doing it's already a mess of duplicates all over the place. My understanding is that just removing the subs from the agent's folder is not enough and the DB needs to also be changed but I could be wrong.

I'm being asked about how to cleanup the disaster made by the opensubtitles plugin (especially now that Sub-Zero seems to be doing this properly at last) and webtools was my "go-to" tool, but I now realize it no longer does this.

Also: When the functionality is put back in, could there be an option to search and delete all plug-in subtitles instead of per-file?

@ukdtom
Copy link
Owner

ukdtom commented Jan 21, 2016

You can find older versions here
https://github.com/dagalufh/WebTools.bundle/releases

But only one version can be installed at a time

And regarding delete all in one go is a good idea, but unsure about the impact here, so need to investigate that a bit more, before deciding

@ukdtom ukdtom modified the milestone: V2.2 Jan 23, 2016
@ukdtom
Copy link
Owner

ukdtom commented Feb 28, 2016

Backend fixed with 0122c6b

Now miss the frontend

@ukdtom ukdtom assigned dagalufh and unassigned ukdtom Feb 28, 2016
dagalufh added a commit that referenced this issue Mar 3, 2016
@dagalufh
V2.2-DEV:
2467ea7 
Internal Note:

	Here we collect stuff that needs to go into the real released changelog, aka acumulated, and only since 2.1 changes here ;-)

BACKEND:

	Fix:

		#115 UAS: Migration fails, if plugin directory contains hidden folder

		#116 UAS: Make UAS work, even if a git is dir levels too low

		#117 UAS and uninstall unknown bundle

		#121 UAS: Cleanup old files/folders when updating

		#122 UAS: bundle migration

		#138 UAS: getAllBundleInfo is reset when UASRepo is updated

	New:

		#129 UAS: Alllow 3.Party devs to clear their stuff

		#135 WT: Tell users, if wrong install path is used

		#137 WT: Add new decorator for auth

		#126 UAS: Allow WebTools to autoupdate

FRONTEND:

	Fix:

		#131 UAS: After changin category, focus is no longer set on inputbox

		#139 UAS: Unknown bundles without url won't be able to be uninstalled or re-installed.

		#140 UAS: Migrate now always goes back to showing ALL available bundles

	New:

		#126 UAS: Allow WebTools to autoupdate

		#142 LogViewer: Search for keywords, highlighting of the same. Jump to top.

		#133 Subtitlemgmt: Added GUI for uploading subtitles

		#112 Subtitlemgmt: Allow delete/view for agent subtitles aswell.
@ukdtom
Copy link
Owner

ukdtom commented Mar 3, 2016

Confirmed working

@ukdtom ukdtom closed this as completed Mar 3, 2016
dagalufh added a commit that referenced this issue Mar 4, 2016
@dagalufh
V2.2-DEV:
42a5fe5 
Internal Note:

	Here we collect stuff that needs to go into the real released changelog, aka acumulated, and only since 2.1 changes here ;-)

BACKEND:

	Fix:

		#115 UAS: Migration fails, if plugin directory contains hidden folder

		#116 UAS: Make UAS work, even if a git is dir levels too low

		#117 UAS and uninstall unknown bundle

		#121 UAS: Cleanup old files/folders when updating

		#122 UAS: bundle migration

		#138 UAS: getAllBundleInfo is reset when UASRepo is updated

	New:

		#129 UAS: Alllow 3.Party devs to clear their stuff

		#135 WT: Tell users, if wrong install path is used

		#137 WT: Add new decorator for auth

		#126 UAS: Allow WebTools to autoupdate

FRONTEND:

	Fix:

		#131 UAS: After changin category, focus is no longer set on inputbox

		#139 UAS: Unknown bundles without url won't be able to be uninstalled or re-installed.

		#140 UAS: Migrate now always goes back to showing ALL available bundles

		#-- Subtitlemgmt: Added more logging for uploads. And fixed error reported by Dane22 about uploads. (2016-03-04)

	New:

		#126 UAS: Allow WebTools to autoupdate

		#142 LogViewer: Search for keywords, highlighting of the same. Jump to top.

		#133 Subtitlemgmt: Added GUI for uploading subtitles

		#112 Subtitlemgmt: Allow delete/view for agent subtitles aswell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagalufh dagalufh

Labels
enhancement
Projects
None yet
Milestone
V2.2
Development

No branches or pull requests
4 participants
@eduo @ukdtom @dagalufh @OttoKerner