Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry mechanism for template installation #428

Merged
merged 2 commits into from
Jun 2, 2018

Conversation

cosmo0920
Copy link
Collaborator

@cosmo0920 cosmo0920 commented Jun 1, 2018

I added retrying mechanism for template installation. Fixes #198

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible
  • feature works in elasticsearch_dynamic (not required but recommended)

@cosmo0920
Copy link
Collaborator Author

Could you try this patch if you can, @kmotrebski ?

@kmotrebski
Copy link

Awesome, it works!

I've tested it with non default values of max_retry_putting_template option that you have added and it works perfectly!

Surprised how quickly this issue was solved! Thanks a lot Mr @cosmo0920 🌞

When it is possible it will reach official release and can be installed from official repository instead of source?

@cosmo0920 cosmo0920 merged commit 13c6cd0 into master Jun 2, 2018
@cosmo0920 cosmo0920 deleted the retry-template-install branch June 2, 2018 02:49
@cosmo0920
Copy link
Collaborator Author

I'd published this patch as v2.10.3.
Thank you for confirming this patch, @kmotrebski !

@kmotrebski
Copy link

@cosmo0920 Super, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants