Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify difference with Crockford's base32 #57

Closed
wants to merge 1 commit into from
Closed

Clarify difference with Crockford's base32 #57

wants to merge 1 commit into from

Conversation

kachick
Copy link

@kachick kachick commented May 1, 2021

ref: #38, ulid/javascript#85, kachick/ruby-ulid#57, oklog/ulid#69, #49

Crockford's base32

Especially when accept iIlLoO mapping as original Crockford's base32 decoding spec, Lexicographically sortable is lost 🤔

@alizain @tuupola How do you think this change?

@kachick kachick changed the title Clarify difference of Crockford's base32 Clarify difference with Crockford's base32 May 1, 2021
- Uses Crockford's base32 for better efficiency and readability (5 bits per character)
- Uses subset of Crockford's base32 for better efficiency and readability (5 bits per character)
- Major difference with `Crockford's base32` is not be able to contain `iIlLoO` and `hyphens(-)`
- All characters except `0123456789ABCDEFGHJKMNPQRSTVWXYZabcdefghjkmnpqrstvwxyz` are invalid in ULID
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know a suggestion exists to restrict only for uppercase #3
But this PR does not scope it 🙇

kachick added a commit to kachick/ruby-ulid that referenced this pull request May 7, 2021
Might be changed in #57 and ulid/spec#57
But this is enough for now
kachick added a commit to kachick/ruby-ulid that referenced this pull request May 17, 2021
Resolves #150

This is a simple solution for following issues

* #78
* #57
* #143
* ulid/spec#57
* ulid/spec#3
@kachick
Copy link
Author

kachick commented May 13, 2024

Closing in favor of ietf-wg-uuidrev/rfc4122bis@6fbd9f0

@kachick kachick closed this May 13, 2024
@kachick kachick deleted the clarify-difference-of-crockford32 branch May 13, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant