-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TensorFlow ops for --nms
and --agnostic-nms
#7281
Merged
glenn-jocher
merged 6 commits into
ultralytics:master
from
leeflix:fix/tflite_export_nms
Apr 5, 2022
Merged
Enable TensorFlow ops for --nms
and --agnostic-nms
#7281
glenn-jocher
merged 6 commits into
ultralytics:master
from
leeflix:fix/tflite_export_nms
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Hello @leeflix, thank you for submitting a YOLOv5 π PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- β Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- β Verify all Continuous Integration (CI) checks are passing.
- β Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
1 task
1 task
glenn-jocher
changed the title
enable TensorFlow ops if flag --nms or --agnostic-nms is used
Enable TensorFlow ops for Apr 5, 2022
--nms
and --agnostic-nms
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
) * enable TensorFlow ops if flag --nms or --agnostic-nms is used * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update export.py * Update export.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Glenn Jocher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Enhancements to TensorFlow Lite (TFLite) export functionality in YOLOv5.
π Key Changes
nms
andagnostic_nms
arguments toexport_tflite
function.ncalib
to a default value of 100.tf.lite.OpsSet.SELECT_TF_OPS
to supported operations whennms
oragnostic_nms
is enabled during TFLite export.π― Purpose & Impact
nms
(Non-Maximum Suppression) andagnostic_nms
parameters aims to allow users more control over the post-processing steps during TFLite model conversion, potentially leading to more efficient on-device inference.ncalib
value helps standardize the quantization calibration step, which can improve the quality of the int8 quantized models.SELECT_TF_OPS
supports a wider range of TensorFlow operations when exporting to TFLite, thereby enhancing model compatibility and performance on a broader set of devices.