Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start-env with new NextStartOptions #2813

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Update start-env with new NextStartOptions #2813

merged 3 commits into from
Jun 28, 2024

Conversation

mho22
Copy link
Contributor

@mho22 mho22 commented Jun 25, 2024

Related to pull request 2314

Corrected error with port and hostname options and removed no more needed array. Based on Next CLI command file

Before

cli.nextStart({
  '--port': process.env.PORT || 3000,
  '--hostname': process.env.HOSTNAME || '0.0.0.0',
  _: [],
});

After

cli.nextStart({
  'port': process.env.PORT || 3000,
  'hostname': process.env.HOSTNAME || '0.0.0.0'
});

mikecao and others added 3 commits June 20, 2024 13:18
Corrected error with port and hostname argument and removed unneeded array.
Copy link

vercel bot commented Jun 25, 2024

@mho22 is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@mho22 mho22 changed the title Updated start-env with new NextStartOptions Update start-env with new NextStartOptions Jun 25, 2024
@mikecao mikecao changed the base branch from master to dev June 28, 2024 03:02
@mikecao mikecao merged commit 6a7dac3 into umami-software:dev Jun 28, 2024
0 of 5 checks passed
@mho22 mho22 deleted the patch-1 branch June 28, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants