Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch login_required from map page and add a way to login #2025

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

yohanboniface
Copy link
Member

This:

  • catch "login_required" from the map page, when hitting the save button
  • proceed the save and close the login page at the end of the login process
  • make sure to update the map user after a save

It's not ideal because when the save process includes a magic link (which can be the case with MonComptePro eg.), the new window will never be closed, and the save will not proceed, so the user will have to close the new window and click save again. Then the map will save and the user name will be shown in the edit toolbar as normal.

But that's the better compromise I can get to…

@davidbgk
Copy link
Contributor

I guess we can close #1733 even if returning a correct status code when login is required would be beneficial anyway.

@yohanboniface yohanboniface force-pushed the login-from-map branch 2 times, most recently from ea0e053 to 180d1eb Compare July 29, 2024 13:31
@yohanboniface yohanboniface merged commit f05590e into master Aug 15, 2024
4 checks passed
@yohanboniface yohanboniface deleted the login-from-map branch August 15, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants